Skip to content

Commit

Permalink
Setting default values in one place
Browse files Browse the repository at this point in the history
Previously default values for certain configuration options were
scattered across multiple places in `ClientOptions`. This commit fixes
this.
  • Loading branch information
JensRantil committed Mar 6, 2012
1 parent d1954ef commit 816187b
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions supervisor/options.py
Expand Up @@ -1406,7 +1406,7 @@ def __init__(self):
self.configroot = Dummy()
self.configroot.supervisorctl = Dummy()
self.configroot.supervisorctl.interactive = None
self.configroot.supervisorctl.prompt = None
self.configroot.supervisorctl.prompt = 'supervisor'
self.configroot.supervisorctl.serverurl = None
self.configroot.supervisorctl.username = None
self.configroot.supervisorctl.password = None
Expand Down Expand Up @@ -1448,10 +1448,13 @@ def read_config(self, fp):
path = normalize_path(path)
serverurl = 'unix://%s' % path
section.serverurl = serverurl
section.prompt = config.getdefault('prompt', 'supervisor')
section.username = config.getdefault('username', None)
section.password = config.getdefault('password', None)
history_file = config.getdefault('history_file', None)

# The defaults used below are really set in __init__ (since
# section==self.configroot.supervisorctl)
section.prompt = config.getdefault('prompt', section.prompt)
section.username = config.getdefault('username', section.username)
section.password = config.getdefault('password', section.password)
history_file = config.getdefault('history_file', section.history_file)

if history_file:
history_file = normalize_path(history_file)
Expand Down

0 comments on commit 816187b

Please sign in to comment.