Make encryption optional #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encryption is now optional and disabled by default, unless the `secret` configuration option is set. This ensures existing installations keep working as expected. The reason for disabling encryption by default is in order for us to be able to use utility commands to setup encryption, for example, generating keys. This would not be possible if encryption would be enabled by default, in which case configuration validation would fail when trying to run the command.
psrpinto
force-pushed
the
feature/optional-encryption
branch
from
f7d04f0
to
9489d25
Compare
fotomerchant
pushed a commit
to fotomerchant/JMSPaymentCoreBundle
that referenced
this pull request
Jul 27, 2018
* develop: Remove paypal plugin dependency (schmittjoh#220) Replace abandoned project by most advanced fork Test for symfony 3.3 No longer build for HHVM Avoid reliance on kernel version Prepare release 1.3.0 Deprecate usage of mcrypt (schmittjoh#200) Add command for generating encryption keys (schmittjoh#208) Make defuse the default encryption provider (schmittjoh#207) Add encryption provider for defuse/php-encryption (schmittjoh#206) Allow custom encryption providers (schmittjoh#205) Make encryption optional (schmittjoh#204) Deprecate payment.encryption_service in favor of payment.crypto.mcrypt (schmittjoh#203) Refactor ExtendedDataType (schmittjoh#202) Fix tests (schmittjoh#199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encryption is now optional and disabled by default, unless the
secretconfiguration option is set. This ensures existing installations keep working as expected.The reason for disabling encryption by default is in order for us to be able to use utility commands to setup encryption, for example, generating keys. This would not be possible if encryption would be enabled by default, in which case configuration validation would fail when trying to run the command.