Merge pull request #892 from dannyvw/profiler

Fix default profiler value
schmittjoh · Sep 12, 2022 · 408ad72 · 408ad72
2 parents f91b701 + 68583b3
commit 408ad72
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -35,7 +35,7 @@ public function getConfigTreeBuilder()
             $root = $tb->root('jms_serializer')->children();
         }
 
-        $root->booleanNode('profiler')->defaultTrue($this->debug)->end();
+        $root->booleanNode('profiler')->defaultValue($this->debug)->end();
 
         $this->addHandlersSection($root);
         $this->addSubscribersSection($root);

diff --git a/Tests/DependencyInjection/ConfigurationTest.php b/Tests/DependencyInjection/ConfigurationTest.php
@@ -282,4 +282,17 @@ public function testJsonSerializationVisitorDefaultOptions()
 
         $this->assertEquals(1024 /*JSON_PRESERVE_ZERO_FRACTION*/, $config['visitors']['json_serialization']['options']);
     }
+
+    public function testDefaultProfiler()
+    {
+        $processor = new Processor();
+        $config = $processor->processConfiguration(new Configuration(true), []);
+
+        $this->assertSame(true, $config['profiler']);
+
+        $processor = new Processor();
+        $config = $processor->processConfiguration(new Configuration(false), []);
+
+        $this->assertSame(false, $config['profiler']);
+    }
 }