Handle lowerCamelCase naming strategy #139

jry25 · 2012-06-27T15:41:34Z

Hi, camel case naming offers two ways to write camel case :

UpperCamelCase, with the first letter on uppercase
lowerCamelCase, with the first letter on lowercase

This pull request handle the use of lowerCamelCase naming, by adding a boolean configuration node "lower_camel_case". The use of UpperCamelCase is used by default or if the configuration node "lower_camel_case" is set to "false"

jry25 · 2012-06-27T15:56:55Z

fixed https://github.com/jry25/JMSSerializerBundle/commit/261cb406f67f26c453f223f3e699c669a6345405
merci pour cette remarque

jry25 · 2012-06-27T15:58:40Z

oops, sorry I didn't want to close this pull request.
I'm a newbie on github, some help will be nice.

schmittjoh · 2012-06-29T19:45:22Z

Do you use upper-case properties?

jry25 · 2012-07-05T15:53:38Z

No, I write the properties with lowerCamelCase

wheelsandcogs · 2012-07-10T14:37:54Z

This would be really useful for APIs that use lowerCamelCase JSON properties.

schmittjoh · 2012-07-10T15:05:46Z

Could you please add/update the tests, and squash your commits?

wedgybo · 2012-07-19T17:08:39Z

@jry25 Cheers for generating this PR. How are you getting on with the changes @schmittjoh requested? If you need help let us know as I'm keen to get this patch in the core bundle

jry25 · 2012-07-21T21:42:41Z

Hi folks,
@schmittjoh and @wedgybo I was extremely busy these times.
I will add/update tests tomorrow.
If I need help I will let you know.
Don't worry, I didn't forget the PR.

jry25 · 2012-07-22T15:05:48Z

Hi, I try to figure out where I should update the tests but can't succeed.
CamelCaseNamingStrategy is only use on BaseSerializationTest and PerformanceTest but I don't know where in the code I have to handle lowerCamelCase naming strategy.
Do you know where I should do that ?

schmittjoh · 2012-07-22T16:02:20Z

A unit test is better suited here, I think. Let's create a CamelCaseNamingStrategyTest.

jry25 · 2012-07-22T16:05:35Z

Thanks. I'll try to write a unit test. I'll keep you up with CamelCaseNamingStrategyTest
About squash the commits is something like this http://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/ that I have to do ?

schmittjoh · 2012-07-22T16:09:15Z

There are probably more elegant ways to squash, here is what I do:

git reset HEAD~4
git add .
git commit

Replace "4" with the number of commits that you have made so far, and do not add the --hard option to the reset command.

jry25 · 2012-07-22T16:12:09Z

Your help is very useful. I did well to ask you some details.

jry25 · 2012-07-22T18:07:26Z

I tried to squash the commits but I'm not sure if it properly worked. The log on my local repo doesn't show it and there's no change online

wedgybo · 2012-07-23T13:04:36Z

git rebase -i 801132b

That commit hash might have to change if there have been any upstream changes since I looked at your repo.

Leave the top commit as pick. Change all the other first words of pick to s or squash in the commit. This will generate a new commit message with all the squashed lines. Delete it all out and put in Adding lower camel case support save then push. Should do the job and end up with a git log like so.

Author: jry25 <jeremy.richard_87@yahoo.fr>
Date:   Wed Jun 27 18:26:57 2012 +0300

Added support for lower camel case

commit 801132b68520b2b1f826a50e4eb12a31e1463303
Author: Johannes <schmittjoh@gmail.com>
Date:   Thu Jun 14 08:50:43 2012 -0500

changed branch alias version

jry25 · 2012-07-23T19:02:33Z

I just tried with the method given by @schmittjoh and @wedgybo but as soon as I sync github MacOS application the squash disappear.
I'm very disappointed I'm fluent in svn but apparently not in git.

stof · 2012-07-23T19:28:16Z

well, do the push with the command-line too. The github application may reject force pushes.

wedgybo · 2012-08-06T14:21:06Z

@jry25 If you open up write access for my account I'm happy to sort the final squash to get this included if you are still having bother with it. Better than copying and generating a new pull request.

jry25 · 2012-08-06T17:54:22Z

When I try to push with command line I get this error :

git push
Username for 'https://github.com': jry25
Password for 'https://jry25@github.com':
To https://github.com/jry25/JMSSerializerBundle.git
! [rejected] master -> master (non-fast-forward)
error: failed to push some refs to 'https://github.com/jry25/JMSSerializerBundle.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Merge the remote changes (e.g. 'git pull')
hint: before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Do I need to do a git pull ?

wedgybo · 2012-08-06T18:09:22Z

I'd guess that the squash has changed history so it's no longer a fast-forward commit. As @stof suggested you'll need to use git push --force as you're changing history. Doing this should be fine so long as no one else is working off your master branch and will be effected by the history change.

jry25 · 2012-08-06T18:33:01Z

Finally I did it. Thanks you very much for your help. Now everything is in the hands of @schmittjoh

wedgybo · 2012-08-06T18:36:15Z

No problem :) Cheers for sorting it out. Will hopefully be able to avoid adding in 100s of SerializedName() annotations now.

alexeyshockov · 2012-09-03T18:08:15Z

Any progress with issue? This option will be extremely useful, IMO.

tleidinger · 2012-10-11T12:23:42Z

Any progress? It refers to this as well #49 doesn't it? It would be super to use lowerCamelCase strategy to deserialize data to Doctrine entity schemes

schmittjoh · 2012-10-11T13:00:41Z

There are still some CS issues, and it would need to be rebased on master.

poussain · 2012-10-23T11:02:34Z

Hi,
What are the CS issues ? Can we do something to help ?

stof · 2012-10-23T22:22:35Z

Tests/Serializer/Naming/CamelCaseNamingStrategyTest.php

+		$translatedPropertyName = $camelCaseNamingStrategy->translateName($metadata->propertyMetadata['camelCaseProperty']);
+
+		$this->assertEquals($translatedPropertyName, 'camel_case_property');
+	}


Please use 4 spaces for the indentation, not tabs

ianunruh · 2012-11-11T22:32:20Z

Doesn't the term "camel case" generally imply that it starts with a lower-case letter in the first place? Pascal case, on the other hand, implies that it starts with an upper-case letter (see Capitalization Styles on MSDN). The name of this naming strategy is a bit misleading because it isn't ACTUALLY camel case. Not only that (and even more perplexing) is the fact that CamelCaseNamingStrategy also supports SEPARATORS and fully lower-case properties. The way I see it, this class should be split into SeparatorNamingStrategy, CamelCaseNamingStrategy and PascalCaseNamingStrategy. That's just my $0.02 though.

stof · 2012-11-21T02:39:26Z

@iunruh no. camel case can be used for both, which is why we may talk about upper camel case (which is also known as Pascal case) and lower camel case.

tiger-seo · 2012-12-10T16:32:37Z

Any progress with issue? This option will be extremely useful, IMO.

jstoeffler · 2012-12-10T17:04:26Z

Apparently someone needs to replaces tabs by spaces... Things like this can take several months.
Personally I'm working with @jry25 's fork.

nifr · 2012-12-10T17:18:03Z

Exactly what i need right now.

Is the tab to spaces conversion everything left to succeed with this PR ?

jry25 · 2012-12-10T20:47:06Z

Hi guys I was totally busy since I created this PR. Hope the commit 93d6a57 will do the job you're looking for. cf https://github.com/jry25/JMSSerializerBundle/commit/93d6a570d18d851c62681fdc53d80f496be77222

jstoeffler · 2012-12-22T09:00:21Z

@schmittjoh any comments on the new commit ?

marcospassos · 2013-01-15T11:38:44Z

Any news?

ianunruh · 2013-01-17T15:57:46Z

You'll probably need to open a PR on the https://github.com/schmittjoh/serializer as well, since the bulk of this component was moved there.

pietervogelaar · 2013-02-04T16:29:42Z

I really need this, when will it be implemented?

marcospassos · 2013-02-15T00:56:48Z

@schmittjoh there is something else that should be made before this PR get merged?

ianunruh · 2013-02-18T05:36:29Z

This pull request might be what most of you are looking for:

schmittjoh/serializer#37

It has already been merged into the master for the actual serializer component. However, the actual configuration change for the bundle is being discussed in this pull request:

#270

jrmyio · 2013-12-22T23:19:11Z

Waiting for this to be merged. Its kind of sad you need 2+ hours of research for this bundle to just behave camel case (with a lower first letter).

imunhatep · 2013-12-26T19:23:09Z

+100 year old issue... common

gbirke · 2014-03-29T14:24:42Z

+1
I'd be very happy if this issue would be resolved.

Ember expects the field names to be CamelCase. Change serializer naming strategy to reflect that. See schmittjoh/JMSSerializerBundle#270 and schmittjoh/JMSSerializerBundle#139

nifr · 2014-05-05T10:50:02Z

ping @schmittjoh

Raphy · 2016-10-24T17:57:05Z

Any news about this PR ?

The solution I've found is to add the parameter in services.yml :

parameters:
    jms_serializer.cache_naming_strategy.class: 'JMS\Serializer\Naming\IdenticalPropertyNamingStrategy'

It works with Symfony 3

Source: gbirke/nvcapp1@3890b28

goetas · 2016-12-19T10:26:06Z

Sorry for the terribly long feedback loop

Closing the PR, since too many things changed on master in the last years. If you are still interested in working on this feel free to re-open a new PR based on the current master.

jry25 closed this Jun 27, 2012

jry25 reopened this Jun 27, 2012

wheelsandcogs mentioned this pull request Jul 10, 2012

"PropertyName" Naming Strategy #49

Closed

schmittjoh mentioned this pull request Jul 31, 2012

Added option for property_naming #155

Closed

stof reviewed Oct 23, 2012
View reviewed changes

Adding lower camel case support

93d6a57

pietervogelaar mentioned this pull request Feb 4, 2013

ucfirst property not supported by PropertyNaming class Spea/JMSSerializerModule#2

Closed

goetas closed this Dec 19, 2016

Handle lowerCamelCase naming strategy #139

Handle lowerCamelCase naming strategy #139

Conversation

jry25 commented Jun 27, 2012

jry25 commented Jun 27, 2012

jry25 commented Jun 27, 2012

schmittjoh commented Jun 29, 2012

jry25 commented Jul 5, 2012

wheelsandcogs commented Jul 10, 2012

schmittjoh commented Jul 10, 2012

wedgybo commented Jul 19, 2012

jry25 commented Jul 21, 2012

jry25 commented Jul 22, 2012

schmittjoh commented Jul 22, 2012

jry25 commented Jul 22, 2012

schmittjoh commented Jul 22, 2012

jry25 commented Jul 22, 2012

jry25 commented Jul 22, 2012

wedgybo commented Jul 23, 2012

jry25 commented Jul 23, 2012

stof commented Jul 23, 2012

wedgybo commented Aug 6, 2012

jry25 commented Aug 6, 2012

wedgybo commented Aug 6, 2012

jry25 commented Aug 6, 2012

wedgybo commented Aug 6, 2012

alexeyshockov commented Sep 3, 2012

tleidinger commented Oct 11, 2012

schmittjoh commented Oct 11, 2012

poussain commented Oct 23, 2012

stof Oct 23, 2012

Choose a reason for hiding this comment

ianunruh commented Nov 11, 2012

stof commented Nov 21, 2012

tiger-seo commented Dec 10, 2012

jstoeffler commented Dec 10, 2012

nifr commented Dec 10, 2012

jry25 commented Dec 10, 2012

jstoeffler commented Dec 22, 2012

marcospassos commented Jan 15, 2013

ianunruh commented Jan 17, 2013

pietervogelaar commented Feb 4, 2013

marcospassos commented Feb 15, 2013

ianunruh commented Feb 18, 2013

jrmyio commented Dec 22, 2013

imunhatep commented Dec 26, 2013

gbirke commented Mar 29, 2014

nifr commented May 5, 2014

Raphy commented Oct 24, 2016 • edited Loading

goetas commented Dec 19, 2016

Raphy commented Oct 24, 2016 •

edited

Loading