-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Symfony 6 #869
Conversation
@@ -18,7 +18,7 @@ class SerializerHelper extends Helper | |||
{ | |||
protected $serializer; | |||
|
|||
public function getName() | |||
public function getName(): string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is typehinted in 6.0.
|
||
$this->assertEquals('bar', $exp->evaluate("service('foo')", ['container' => $container])); | ||
$this->assertEquals($object, $exp->evaluate("service('foo')", ['container' => $container])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The container is typehinted to return objects from Container::get()
in 6.0.
"symfony/finder": "^3.0 || ^4.0 || ^5.0 || ^6.0", | ||
"symfony/form": "^3.0 || ^4.0 || ^5.0 || ^6.0", | ||
"symfony/stopwatch": "^3.0 || ^4.0 || ^5.0 || ^6.0", | ||
"symfony/templating": "^3.0 || ^4.0 || ^5.0 || ^6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The templating component wasn't being loaded in at all previously, so now it's included for dev and a basic test class added in.
thanks! |
Adds Symfony 6 support and fixes the small issues with the new version installed.