Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop collecting metadata from cache #900

Merged
merged 1 commit into from Sep 12, 2022

Conversation

scyzoryck
Copy link
Collaborator

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #899
License MIT

Instead of collecting data about metadata from cache we can decorate the factory itself.

@goetas goetas merged commit f91b701 into schmittjoh:master Sep 12, 2022
@goetas
Copy link
Collaborator

goetas commented Sep 12, 2022

good idea

@smoench
Copy link

smoench commented Sep 12, 2022

@goetas Unfortunately it was not a good idea merging it without a successfully test run. Currently the latest release is broken due to:

TypeError : JMS\SerializerBundle\Debug\DataCollector::__construct(): Argument #4 ($metadataDriver) must be of type JMS\SerializerBundle\Debug\TraceableDriver, JMS\SerializerBundle\Debug\TraceableMetadataFactory given,

Please consider merging #897 to enable the CI checks again. When it is merged I can provide a fix.

@jdreesen
Copy link
Contributor

I just noticed that all pipelines are failing, too, and created a PR #901 to fix this. I now closed it again, as it's a duplicate of #897.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants