Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jms/serializer-bundle breaking change #2073

Closed
gjorgic opened this issue Sep 13, 2022 · 5 comments
Closed

jms/serializer-bundle breaking change #2073

gjorgic opened this issue Sep 13, 2022 · 5 comments

Comments

@gjorgic
Copy link
Contributor

gjorgic commented Sep 13, 2022

Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no

I have installed coreshop/core-shop: 3.0.0-beta.5 and at the some point composer pkg jms/serializer-bundle was updated from 4.0.1 to 4.1.0 and that cause following error

image (23)

@jdreesen
Copy link
Contributor

That's a bug in v4.1.0 of jms/serializer-bundle. See here, schmittjoh/JMSSerializerBundle#902 and schmittjoh/JMSSerializerBundle#904

@dpfaffenbauer
Copy link
Member

maybe we should just make a conflict with 4.1.0 as 4.1.1 might fix it

@gjorgic
Copy link
Contributor Author

gjorgic commented Sep 13, 2022

so i need just put this in composer.json?

...
"conflict": {
    "jms/serializer-bundle": "4.1.0"
},
...

@dpfaffenbauer
Copy link
Member

yes

@gjorgic
Copy link
Contributor Author

gjorgic commented Sep 13, 2022

Ok, i change this in same MR #2074

dpfaffenbauer added a commit that referenced this issue Sep 13, 2022
fix #2073 by locking pkg version to 4.0.*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants