Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twig 3 support #516

Closed
JonasWijne opened this issue Nov 21, 2019 · 3 comments
Closed

Twig 3 support #516

JonasWijne opened this issue Nov 21, 2019 · 3 comments

Comments

@JonasWijne
Copy link

Q A
Bundle version n.a
Symfony version 4.4
PHP version 7.2

Expected behavior

symfony 4.4 requires twig ^3.0
@goetas
Copy link
Collaborator

goetas commented Nov 22, 2019

feel free to send a PR with feature. I'm not aware of which changes have been introduced in twig 3.0 yet.

greg0ire added a commit to greg0ire/JMSTranslationBundle that referenced this issue Feb 5, 2020
@greg0ire
Address namespace change in Twig
5908dc7 
Refs schmittjoh#516
@greg0ire greg0ire mentioned this issue Feb 5, 2020
Merged
greg0ire added a commit to greg0ire/JMSTranslationBundle that referenced this issue Feb 6, 2020
@greg0ire
Address namespace change in Twig
829bba1 
Refs schmittjoh#516
@goetas
Copy link
Collaborator

goetas commented Feb 21, 2020

#519 should make it easier to add twig 3 support

@franmomu franmomu mentioned this issue Mar 5, 2020
Merged
3 tasks
@goetas
Copy link
Collaborator

goetas commented Apr 19, 2020

done in #530

@goetas goetas closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goetas @JonasWijne