Allow Symfony 5 and Twig 3 #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
uuuuu! this is nice! looking forward to it! |
franmomu
force-pushed
the
symfony5
branch
3 times, most recently
from
8ab2fe5
to
ab27217
Compare
|
Apparently when #529 gets merged, it would only need to add return |
|
#529 is merged now! |
franmomu
force-pushed
the
symfony5
branch
2 times, most recently
from
ae25b15
to
cc0a0db
Compare
|
I removed the use in tests of |
|
I'm pretty happy with the result, let me know if you are done so I can merge it :) |
I think it's fine! |
|
Thanks and excellent work lately! |
This was referenced Apr 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to make the bundle compatible with Symfony 5 and Twig 3
Todos