Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Translation Contracts #528

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Allow Translation Contracts #528

merged 1 commit into from
Mar 4, 2020

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Mar 4, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Description

symfony/translation was in the require-dev section of the composer.json, but the translator service is used in services.xml, so I moved it to the required section and also added translation-contracts for Symfony 5.

@franmomu franmomu mentioned this pull request Mar 4, 2020
Closed
@goetas
Copy link
Collaborator

goetas commented Mar 4, 2020

thanks!

@goetas goetas merged commit 13369ae into schmittjoh:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @goetas