Remove extending from ContainerAwareCommand #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I think that we can consider this as not-BC. People should not have extended those command IMO. @gnat42 what do you think? Can we remove completly the setContainer/getContainer methods? |
|
i've forgot about it, but did you check https://github.com/schmittjoh/JMSTranslationBundle/pull/515/files ? |
Yes, It does the same thing but with the container and using |
|
Hey @goetas, I think its fine to remove that. Extending the commands makes no sense so even if it was a break, I kinda feel like its one that is ok. |
franmomu
force-pushed
the
remove_command_deprecations
branch
from
4081259
to
dd939d0
Compare
|
Thanks for your work |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed extending from
ContainerAwareCommandby extending fromCommandand addinggetContainerandsetContainermethods and also callingsetContainerfrom the service declaration. I think it is BC, but maybe I'm missing something.