Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirejs integration #25

Closed
kimlai opened this issue May 6, 2013 · 1 comment
Closed

requirejs integration #25

kimlai opened this issue May 6, 2013 · 1 comment

Comments

@kimlai
Copy link

kimlai commented May 6, 2013

Hi.

I'm trying to integrate twig-js with requirejs in a Symfony2 project. I tweaked the ModuleCompiler to output require-js compatible modules instead of the global google closure "provide" variable, but I can't find a not-to-messy way of replacing the original ModuleCompiler by my custom one. Does it sound like the way to go to produce templates in amd format ? Is there any chance this would be supported in the future ?

Thanks.
kimlai added a commit to kimlai/twig.js that referenced this issue Feb 2, 2014
@kimlai
Change the scope of ModuleCompiler->functionName to protected.
2f2c22d 
This is related to
schmittjoh/JMSTwigJsBundle#25. To be able to
output AMD compatible templates, I extended the `ModuleCompiler` (see
https://github.com/kimlai/melikeyradio/blob/master/src/MeLikey/WebAppBundle/TwigJs/Compiler/AmdModuleCompiler.php),
but to do so I need the access the `functionName` property in the child
class.
@kimlai kimlai mentioned this issue Feb 2, 2014
Closed
@kimlai
Copy link
Author

kimlai commented Apr 6, 2014

Addressed in schmittjoh/twig.js@b8b5c10.

@kimlai kimlai closed this as completed Apr 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kimlai