Revert "Move type check when deserializing into the graph navigator" #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not have metadata
goetas
force-pushed
the
revert-1080-metadata-check
branch
from
36ef2a7
to
6802d67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1080
Closes #1102
This bugfix resolves a regression introduced in #1080 and reported in #1102
The thing is that the JSON visitor complains about a missing type right before visiting that property.
Te XML visitor complains immediately, even if the property is not present in the data to visit.
To align the behavior of the two visitors I have relaxed the XML visitor. This unfortunately now had duplicated the check for metadata... that is kinda ugly (and should be fixed).