Revert "Move type check when deserializing into the graph navigator"

src/Exception/RuntimeException.php

@@ -11,4 +11,12 @@
  */
 class RuntimeException extends \RuntimeException implements Exception
 {
+    public static function noMetadataForProperty(string $class, string $prop): self
+    {
+        return new RuntimeException(sprintf(
+            'You must define a type for %s::$%s.',
+            $class,
+            $prop
+        ));
+    }
 }

src/GraphNavigator/DeserializationGraphNavigator.php

@@ -198,10 +198,6 @@ public function accept($data, ?array $type = null)
                         continue;
                     }
 
-                    if (!$propertyMetadata->type) {
-                        throw new RuntimeException(sprintf('You must define a type for %s::$%s.', $propertyMetadata->class, $propertyMetadata->name));
-                    }
-
                     $this->context->pushPropertyMetadata($propertyMetadata);
                     try {
                         $v = $this->visitor->visitProperty($propertyMetadata, $data);

src/JsonDeserializationVisitor.php

@@ -152,23 +152,31 @@ public function startVisitingObject(ClassMetadata $metadata, object $object, arr
      */
     public function visitProperty(PropertyMetadata $metadata, $data)
     {
+        $name = $metadata->serializedName;
+
         if (null === $data) {
-            return null;
+            return;
         }
 
         if (!\is_array($data)) {
             throw new RuntimeException(sprintf('Invalid data %s (%s), expected "%s".', json_encode($data), $metadata->type['name'], $metadata->class));
         }
 
         if (true === $metadata->inline) {
+            if (!$metadata->type) {
+                throw RuntimeException::noMetadataForProperty($metadata->class, $metadata->name);
+            }
             return $this->navigator->accept($data, $metadata->type);
         }
 
-        $name = $metadata->serializedName;
         if (!array_key_exists($name, $data)) {
             throw new NotAcceptableException();
         }
 
+        if (!$metadata->type) {
+            throw RuntimeException::noMetadataForProperty($metadata->class, $metadata->name);
+        }
+
         return null !== $data[$name] ? $this->navigator->accept($data[$name], $metadata->type) : null;
     }
 

src/XmlDeserializationVisitor.php

@@ -282,18 +282,27 @@ public function visitProperty(PropertyMetadata $metadata, $data)
         $name = $metadata->serializedName;
 
         if (true === $metadata->inline) {
+            if (!$metadata->type) {
+                throw RuntimeException::noMetadataForProperty($metadata->class, $metadata->name);
+            }
             return $this->navigator->accept($data, $metadata->type);
         }
         if ($metadata->xmlAttribute) {
             $attributes = $data->attributes($metadata->xmlNamespace);
             if (isset($attributes[$name])) {
+                if (!$metadata->type) {
+                    throw RuntimeException::noMetadataForProperty($metadata->class, $metadata->name);
+                }
                 return $this->navigator->accept($attributes[$name], $metadata->type);
             }
 
             throw new NotAcceptableException();
         }
 
         if ($metadata->xmlValue) {
+            if (!$metadata->type) {
+                throw RuntimeException::noMetadataForProperty($metadata->class, $metadata->name);
+            }
             return $this->navigator->accept($data, $metadata->type);
         }
 
@@ -304,6 +313,9 @@ public function visitProperty(PropertyMetadata $metadata, $data)
             }
 
             $this->setCurrentMetadata($metadata);
+            if (!$metadata->type) {
+                throw RuntimeException::noMetadataForProperty($metadata->class, $metadata->name);
+            }
             $v = $this->navigator->accept($enclosingElem, $metadata->type);
             $this->revertCurrentMetadata();
             return $v;
@@ -341,6 +353,9 @@ public function visitProperty(PropertyMetadata $metadata, $data)
             $this->setCurrentMetadata($metadata);
         }
 
+        if (!$metadata->type) {
+            throw RuntimeException::noMetadataForProperty($metadata->class, $metadata->name);
+        }
         return $this->navigator->accept($node, $metadata->type);
     }
 

tests/Fixtures/ParentNoMetadata.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace JMS\Serializer\Tests\Fixtures;
+
+class ParentNoMetadata
+{
+    public $foo;
+}

tests/Fixtures/ParentNoMetadataChildObject.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace JMS\Serializer\Tests\Fixtures;
+
+use JMS\Serializer\Annotation as Serializer;
+
+class ParentNoMetadataChildObject extends ParentNoMetadata
+{
+    /**
+     * @Serializer\Type("string")
+     *
+     * @var string
+     */
+    public $bar;
+}

tests/Serializer/BaseSerializationTest.php

@@ -86,6 +86,7 @@
 use JMS\Serializer\Tests\Fixtures\ObjectWithVirtualProperties;
 use JMS\Serializer\Tests\Fixtures\Order;
 use JMS\Serializer\Tests\Fixtures\ParentDoNotSkipWithEmptyChild;
+use JMS\Serializer\Tests\Fixtures\ParentNoMetadataChildObject;
 use JMS\Serializer\Tests\Fixtures\ParentSkipWithEmptyChild;
 use JMS\Serializer\Tests\Fixtures\PersonSecret;
 use JMS\Serializer\Tests\Fixtures\PersonSecretMore;
@@ -148,6 +149,15 @@ public function testSerializeNullArray()
         );
     }
 
+    public function testNoMetadataNeededWhenDeSerializingNotUsedProperty()
+    {
+        /** @var ParentNoMetadataChildObject $dObj */
+        $object = $this->deserialize($this->getContent('ParentNoMetadataChildObject'), ParentNoMetadataChildObject::class);
+
+        self::assertSame('John', $object->bar);
+        self::assertNull($object->foo);
+    }
+
     public function testDeserializeObjectWithMissingTypedArrayProp()
     {
         /** @var ObjectWithTypedArraySetter $dObj */

tests/Serializer/GraphNavigatorTest.php

@@ -6,7 +6,6 @@
 
 use Doctrine\Common\Annotations\AnnotationReader;
 use JMS\Serializer\Accessor\DefaultAccessorStrategy;
-use JMS\Serializer\Annotation as Serializer;
 use JMS\Serializer\Construction\UnserializeObjectConstructor;
 use JMS\Serializer\DeserializationContext;
 use JMS\Serializer\EventDispatcher\EventDispatcher;
@@ -164,11 +163,6 @@ protected function setUp()
 
 class SerializableClass
 {
-    /**
-     * @Serializer\Type("string")
-     *
-     * @var string
-     */
     public $foo = 'bar';
 }
 

tests/Serializer/JsonSerializationTest.php

@@ -123,6 +123,7 @@ protected function getContent($key)
             $outputs['iterator'] = '{"iterator":{"foo":"bar","bar":"foo"}}';
             $outputs['array_iterator'] = '{"iterator":{"foo":"bar","bar":"foo"}}';
             $outputs['generator'] = '{"generator":{"foo":"bar","bar":"foo"}}';
+            $outputs['ParentNoMetadataChildObject'] = '{"bar":"John"}';
         }
 
         if (!isset($outputs[$key])) {

tests/Serializer/xml/ParentNoMetadataChildObject.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<result>
+  <bar><![CDATA[John]]></bar>
+</result>