Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the ORM tests using an attribute driver when able #1517

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Oct 12, 2023

Q A
Bug fix? no
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets Partially #1516
License MIT

This PR changes the test suite to run the ORM's integration tests configuring the entity manager to use the attribute driver on PHP 8 and it exists, falling back to the annotation driver when not available. The bulk of this PR is actually adding attributes to all the fixture classes, there're only 3 test classes that actually changed.

@scyzoryck scyzoryck merged commit 9c2ac39 into schmittjoh:master Oct 17, 2023
21 of 23 checks passed
@mbabker mbabker deleted the orm-3-compat-fixes branch October 17, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants