Use namespace from bottom of object stack #718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
reviewed
Mar 10, 2017
| @@ -454,7 +454,7 @@ private function addNamespaceAttributes(ClassMetadata $metadata, \DOMElement $el | |||
|
|
|||
| private function createElement($tagName, $namespace = null) | |||
| { | |||
| if (null === $namespace) { | |||
| if (null === $namespace || $this->document->isDefaultNamespace($namespace)) { | |||
There was a problem hiding this comment.
this is not always true.
elements should be created in their namespace, if they belong to one. then the dom parser will take care of converting it into the correct xml reppresentation
There was a problem hiding this comment.
what you are trying to solve, i tried it with #644
goetas
reviewed
Mar 10, 2017
| @@ -295,7 +295,7 @@ public function visitProperty(PropertyMetadata $metadata, $object, Context $cont | |||
| if (null !== $metadata->xmlNamespace) { | |||
| $element = $this->createElement($elementName, $metadata->xmlNamespace); | |||
| } else { | |||
| $defaultNamespace = $this->getClassDefaultNamespace($this->objectMetadataStack->top()); | |||
| $defaultNamespace = $this->getClassDefaultNamespace($this->objectMetadataStack->bottom()); | |||
There was a problem hiding this comment.
your tests are not covering this line, running
vendor/bin/phpunit --filter=testObjectWithNamespacesAndListInList this line is never executed
|
can you also rebase your PR ? |
|
I went a bit deeper in the analysis. Just add
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered problems with unserializing xml lists in xml lists with a default namespace from the root element.
The cause is, that you use the top element of the stack (newest one) not the bottom element (root).
I also added a test which fails with the previous implementation.