Fix DoctrineObjectConstructor deserialization with naming strategies #951
Conversation
| @@ -87,11 +88,19 @@ public function construct(VisitorInterface $visitor, ClassMetadata $metadata, $d | |||
| $identifierList = array(); | |||
|
|
|||
| foreach ($classMetadata->getIdentifierFieldNames() as $name) { | |||
| if (!array_key_exists($name, $data)) { | |||
| if (method_exists($visitor, 'getNamingStrategy')) { | |||
There was a problem hiding this comment.
cant you check if $visitor instanceof AbstractVisitor?
There was a problem hiding this comment.
i`m going to change this. but i think it will break the current master since the method "getNamingStrategy" was removed.
See: 9e3fd4d#diff-04059dbc4f97e37925ef18e828ce4f5b
i`m going to rework this merge request this Sunday.
i hope this pull request helps you to pinpoints the error from #806
There was a problem hiding this comment.
when this will be backported to master, things are easier since the name is now always part of metadata, it will be enough
$dataName = $metadata->propertyMetadata[$name]->serializedName;
|
Thanks a lot for the contribution. |
goetas
changed the title
|
Sure MIT licence is fine. |
|
@re2bit do you think schmittjoh/JMSSerializerBundle#687 could be connected to your work done here? |
Use NamingStrategy to determine which array key in data should be used.
This should fix Error #806.
Problem Analysis:
While Object construction $data is used as Source for Doctrine Identifier Fields.
Since $data is either a raw array the names are not converted yet.