Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Split property selection from graph navigator #964

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

goetas
Copy link
Collaborator

@goetas goetas commented Jun 12, 2018

Q A
Bug fix? no
New feature? yes
Doc updated no
BC breaks? yes
Deprecations? no
Tests pass? no
Fixed tickets -
License MIT

This changes a bit the way how the serializer internally works. The solution is still ugly and does not work (yet) but has big potentials.

With this implementation:

  • the property selection depends only on the current exclusion strategy, and since the exclusion strategy does not change during the whole graph visitor, can easily be cached (and even compiled for group/version based exclusion strategies)
  • the property access depends only on the class metadata and can be easily compiled into static classes. in addition now the property access can be done in batch, using a single closure for property access (compilation ca be easily done using symfony expression language)

Feedback (and help) is welcome

@goetas goetas added the RFC label Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant