Increase number of citations returned by citedby #446
Conversation
…-package/develop Release v1.7.2
|
I would normally ask people to add a unit test that covers the new addition, but I don't think we should have a test that will scrape 100+ pages :-| |
|
I want to merge #445 to |
arunkannawadi
force-pushed
the
develop
branch
from
53385c3
to
dde44c3
Compare
There was a problem hiding this comment.
This is a good starting point for me to work on this, but I don't think I want to merge this as it is. I'm going to change the base branch to another branch so I could clean it up a bit more. I will also cook up a unit test that will still cover the newly added code.
| self.logger.warning("Object not supported for bibtex exportation") | ||
| return | ||
|
|
||
| if object["bib"]["citedby"] < 999: |
There was a problem hiding this comment.
This should be <= 1000
| pub_id = int(object["citedby_url"].split("=")[1].split("&")[0]) | ||
| iter_list = [] | ||
| while year_low < year_end: | ||
| iter_list.append(self.search_citedby(publication_id=pub_id, year_low=year_low, year_high=year_low+1)) |
There was a problem hiding this comment.
year_high should be the same as year_low. This actually fetches citations from two years instead of one year.
| iter_list.append(self.search_citedby(publication_id=pub_id, year_low=year_low, year_high=year_low+1)) | ||
| year_low += 1 | ||
|
|
||
| return itertools.chain(*iter_list) |
There was a problem hiding this comment.
Using yield from syntax would be much cleaner and would avoid importing itertools.
|
@arunkannawadi Gotcha, looking forward to the next release :) |
Fixes #444
Description
This allows
citedbyto return more than 1k citations, bypassing the problem with Google Scholar only display 100 pages.Checklist
developand notmain.If you don't have a premium proxy, some of the tests will be skipped.
The tests that are run should pass without raising
MaxTriesExceededExceptionor other exceptions.