Modified test suite to use Tor, to improve reliability #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bielsnohr
requested changes
May 13, 2020
Comment on lines
+7
to
+10
| def setUp(self): | ||
| # Testing using Tor, as other proxies tend to be less reliable | ||
| proxies = {'http' : 'socks5://127.0.0.1:9050', 'https': 'socks5://127.0.0.1:9050'} | ||
| scholarly.use_proxy(**proxies) |
There was a problem hiding this comment.
It would be nice if this could be made optional in case a Tor proxy isn't running. My naive approach below didn't work because of some weird exception handling going on in the requests module. If you can think of another way to achieve this, that would be great.
Suggested change
| def setUp(self): | |
| # Testing using Tor, as other proxies tend to be less reliable | |
| proxies = {'http' : 'socks5://127.0.0.1:9050', 'https': 'socks5://127.0.0.1:9050'} | |
| scholarly.use_proxy(**proxies) | |
| proxy_flag = True | |
| def setUp(self): | |
| # Try testing using Tor, as other proxies tend to be less reliable | |
| proxies = {'http' : 'socks5://127.0.0.1:9050', 'https': | |
| 'socks5://127.0.0.1:9050'} | |
| if self.proxy_flag: | |
| try: | |
| scholarly.use_proxy(**proxies) | |
| except Exception: | |
| print("Tor proxy not working. Continuing without...") | |
| self.proxy_flag = False |
|
Closing this. Tried to address the issues raised at #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified test suite to use Tor as proxies for the requests against scholar.