Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST: Ability to enable only dictionary/definition function if language is the same as the default. #43

Closed
moz1984 opened this issue Sep 3, 2018 · 1 comment

Comments

@moz1984
Copy link

moz1984 commented Sep 3, 2018

I use this add-on on Firefox often to find the definition of a word in English, rather than only for translations. It would be great to have a way whereby the add-on detects if the language is the user's default/native language and only provides the definition of the word, rather than a translation (which makes no sense if the translation is from, for example, English -> English) followed by a definition further down the iframe. This could be accomplished maybe either by a setting (user sets default/native language, or by hiding the translation part if the language detected is the same as the language to which a word is being translated.

Firefox 61.0.2, 64-bit
Windows 10

Repository owner deleted a comment from Vendetta7802 May 22, 2019
@schomery
Copy link
Owner

Thanks for the feature request. It is more reliable, If we check for the phrase "Definitions of " in the translator's page. If it is available, then the translation section will be hidden by default. To support other languages, there is a new option to change this phrase.

schomery added a commit that referenced this issue May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants