Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column pure rendering with resize issue #533

Closed
stepanvanzuriak opened this issue May 19, 2020 · 3 comments
Closed

Column pure rendering with resize issue #533

stepanvanzuriak opened this issue May 19, 2020 · 3 comments
Milestone
v1.1.1

Comments

@stepanvanzuriak
Copy link

If you use pure rendering and column resize some columns may become unacceptable for scrolling

Current Behavior

Wrong resize when column use pure rendering

Steps to Reproduce (for bugs)

Codesandbox: https://codesandbox.io/s/zealous-hofstadter-bb9bf?file=/src/App.js

RECORD
@stepanvanzuriak stepanvanzuriak changed the title Column pure rendering and column resize issue Column pure rendering and resize issue May 19, 2020
@stepanvanzuriak stepanvanzuriak changed the title Column pure rendering and resize issue Column pure rendering with resize issue May 19, 2020
@wcjordan
Copy link
Member

Thanks for filing, the codesandbox is very helpful! It looks like our pureRendering logic causes cells to not re-render when only the width is changed. I'll take a look and see if it can be fixed.

wcjordan added a commit that referenced this issue May 20, 2020
@wcjordan
Fix an issue where column resize may not result in cells (#533)
24f1618 
This happens if the resize also causes a scroll
@wcjordan wcjordan mentioned this issue May 20, 2020
Closed
7 tasks
@wcjordan
Copy link
Member

Put a fix up for PR w/ #535

wcjordan added a commit that referenced this issue May 27, 2020
@wcjordan
Fix an issue where column resize may not result in cells (#533)
c551fdd 
This happens if the resize also causes a scroll
@wcjordan wcjordan mentioned this issue May 27, 2020
Merged
7 tasks
wcjordan added a commit that referenced this issue May 27, 2020
@wcjordan
Fix an issue where column resize may not result in cells (#533) (#538)
333bab6 
This happens if the resize also causes a scroll
@wcjordan wcjordan added this to the v1.1.1 milestone May 27, 2020
@wcjordan
Copy link
Member

This fix is now released w/ v.1.1.1

@pradeepnschrodinger pradeepnschrodinger mentioned this issue Oct 25, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
2 participants
@wcjordan @stepanvanzuriak