Fix an issue where column resize may not result in cells (#533) #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens if the resize also causes a scroll
|
@pradeepnschrodinger do you think we should cut a 1.1.1 for this or wait for 1.2? |
wcjordan
commented
May 20, 2020
| @@ -108,8 +108,8 @@ class FixedDataTableCell extends React.Component { | |||
| return true; | |||
| } | |||
|
|
|||
| const { cell: oldCell, isScrolling: oldIsScrolling, ...oldProps } = this.props; | |||
| const { cell: newCell, isScrolling: newIsScrolling, ...newProps } = nextProps; | |||
There was a problem hiding this comment.
Removing this so that when we stop scrolling we will re-render. What could happen before is other prop changes while scrolling would be dropped and we weren't re-rendering once the scroll stopped.
pradeepnschrodinger
approved these changes
May 26, 2020
|
Replaced by #538 so we can target v1.1 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When cell props change while a scroll is happening they don't cause cell's to re-render as expected.
In the issue #533 the resize also causes a horizontal scroll which leads to this issue.
Motivation and Context
See #533
How Has This Been Tested?
Replicated the codepen from the linked issue with our ResizeExample. Reproduced and fixed there.
Screenshots (if appropriate):
Types of changes
Checklist: