Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use open source projects for default styling #61

Open
wcjordan opened this issue Oct 9, 2016 · 1 comment
Open

Use open source projects for default styling #61

wcjordan opened this issue Oct 9, 2016 · 1 comment

Comments

@wcjordan
Copy link
Member

wcjordan commented Oct 9, 2016

Expected Behavior

We should use open source projects for default styling. Potentially looking at CSS in JS approaches. This will make it easier for folks to jump into the project and help improve the default styling or create default styling themes as suggested in #60

Current Behavior

We currently use internal Facebook utilities for applying styles. This approach is not well understood or documented, and can lead to issues when applying custom styling to the grid.

Possible Solution

Consider using Aphrodite or another alternative to replace the Facebook utilities

Steps to Reproduce (for bugs)

Your Environment

  • Version used: 0.7.5
  • Browser Name and version:
  • Operating System and version (desktop or mobile):
  • Link to your project:
@philcockfield
Copy link
Contributor

Potentially looking at CSS in JS approaches.

+1 for this. I see you using aphrodite ... having this component be completely self-contained without the need for CSS, along with a powerful style extensibility model via JS (as outlined in #60 ) would be awesome!

Beautiful module guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants