Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default styling should make custom styling possible / easy #60

Open
wcjordan opened this issue Oct 9, 2016 · 6 comments
Open

Default styling should make custom styling possible / easy #60

wcjordan opened this issue Oct 9, 2016 · 6 comments

Comments

@wcjordan
Copy link
Member

wcjordan commented Oct 9, 2016

Expected Behavior

It should be easy to apply custom styles to the grid.

Current Behavior

The default styling does too much and is not well organized. This makes it difficult apply custom styling in many cases. A few examples are:

Wraps on default cell make styling hard. Can't style the border of FixedDataTableCellDefault
Also when table width > total column width, it's difficult to style the extra header space.

Possible Solution

Consider making default styles into themes which can easily be applied or removed depending on the needs of each use case.

Steps to Reproduce (for bugs)

Your Environment

  • Version used: 0.7.5
  • Browser Name and version: Chrome 53
  • Operating System and version (desktop or mobile): Mac OSX Yosemite
  • Link to your project:
@KamranAsif
Copy link
Contributor

@wcjordan Can we close this in favor of #61 ?

@wcjordan
Copy link
Member Author

wcjordan commented Apr 6, 2017

I want to keep them both open as they have distinct deliverables and may have separate conversations. We can mark them both as future enhancements though (post 1.0)

@leafoflegend
Copy link

leafoflegend commented Jul 7, 2017

The table I built for work I was able to get Radium to take over instead of the CSS sheet. Helped in numerous ways in easily getting to production. This was our thought exactly, how can we easily modify styles going forward. I can probably get a PR with the basic setup for this over. I haven't noticed any sort of performance loss, but I don't know how hard you guys work the table.

Also, of course too many people on our team are anti-CSS so I was having a hard time getting anything except CSS-in-JS through review.

@wcjordan
Copy link
Member Author

wcjordan commented Jul 7, 2017

Cool, we're definitely looking to explore new ideas here. If you could create a PR or example of how you used Radium, I think that would be very useful as we plan for future FDT versions.

@apieceofbart
Copy link

@wcjordan In the light of #531 - wouldn't a simple solution be to expose more classNames on the elements that could overwrite the defaults?
Perhaps leave the very basic styling as default (just the positioning) and leave the rest to user ?

@wcjordan
Copy link
Member Author

That would be an easy to implement solution. I think the downside is it may prove brittle and difficult to maintain if we change the tables DOM structure. One approach might be to add a way to set classnames on elements, but to name all the props with experimental so users aren't surprised if they break on upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants