Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we add space between each row? #515

Closed
datavisorfrankhe opened this issue Feb 22, 2020 · 1 comment
Closed

can we add space between each row? #515

datavisorfrankhe opened this issue Feb 22, 2020 · 1 comment

Comments

@datavisorfrankhe
Copy link

Hello,
We have a requirement to add space between each row, and also, remove the border completely. Making it look like the list, not the data table.
May I ask what will be the best approach to meet this requirement?
I tried to add margin to the row wrapper, but useless. I saw the row position is absolutely, just adding margin is useless here.

Thanls

@wcjordan
Copy link
Member

Unfortunately, we don't have the best solutions for custom styling the table. Some ideas & challenges are tracked under #60 & #61, please feel free to add your use case and any suggestions there.

A couple ideas to try for the space between rows would be:

  1. Try making your row height larger than necessary (row height + empty space height) and then have the individual cell renderers only render content into the row height space, leaving the empty space blank.
  2. Try using the subRowHeightGetter & rowExpanded props to add a sub row as the spacer between rows. (see the Expanded Rows example).

I'm going to close this issue so we can consolidate the discussion under issues #60 & #61. But feel free to continue to post here if you have any questions and I'll answer the best I can. Also if you do get something working, a PR with an example would be great. It would also ensure we don't break your workaround when we go to address #60 & #61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants