-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right click action support. #286
Conversation
Sweet, this looks good to me. Let me try it out this week, and then we can merge it in. If it's not too much work could you add an example demonstrating it's use? |
@@ -271,6 +271,13 @@ Callback that is called when a row is double clicked. | |||
type: `func` | |||
|
|||
|
|||
### `onRowContextMenu` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should add this to api-v0.5
This is only being added to 0.6+ right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 docs are autogenerated, so we don't need to change this file.
LGTM |
I created a new PR addressing your comments: #301 |
Closing in favor of #301 |
Released with v0.8.11 |
Adds support for right click actions on table rows.
Description
Added an onRowContextMenu prop to the Table component that allows a right click handler to be defined for rows.
Motivation and Context
Applies a PR from the original fixed-data-table. Addresses #33.
How Has This Been Tested?
Not formally tested, but a test implementation was created and is stable. In short, this displays the row index in the console as expected when right clicking in a row:
Types of changes
Checklist: