Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On row context menu #301

Merged
merged 5 commits into from
Mar 3, 2018
Merged

On row context menu #301

merged 5 commits into from
Mar 3, 2018

Conversation

difelice
Copy link
Contributor

@difelice difelice commented Mar 2, 2018

Description

Add onRowContextMenu callback.

Motivation and Context

Address issue #33

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@difelice difelice mentioned this pull request Mar 2, 2018
Closed
7 tasks
wcjordan
wcjordan approved these changes Mar 3, 2018
View reviewed changes
Copy link
Member

@wcjordan wcjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll merge and cut a release soon

@wcjordan wcjordan merged commit 7af58f1 into schrodinger:master Mar 3, 2018
@wcjordan
Copy link
Member

wcjordan commented Mar 6, 2018

Released with v0.8.11

@pradeepnschrodinger pradeepnschrodinger mentioned this pull request Jan 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcjordan wcjordan wcjordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@difelice @wcjordan @sli