Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resize cell indicator not showing when maxHeight #703

Conversation

daniela-mateescu
Copy link
Contributor

@daniela-mateescu daniela-mateescu commented Nov 8, 2023

Description

When we use maxHeight instead of height prop the tableHeight which is calculated and passed to ResizeCell plugin is undefined. Due to which resizerLineHeight is undefined and we are unable to see the resizer line

Motivation and Context

The resize line is shown only when the table is configures by setting the height property. It is not shown when the table is configured using only maxHeight. The changes fix this issue

Fixes: #704

How Has This Been Tested?

Screenshots (if appropriate):

https://www.youtube.com/watch?v=dVY1S15phRY

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

src/api/apiData.js Outdated Show resolved Hide resolved
src/api/apiData.js Outdated Show resolved Hide resolved
@karry08
Copy link
Collaborator

karry08 commented Nov 8, 2023

hi @daniela-mateescu thanks a lot for the PR as well. The approach seems correct but i have some suggestions, let me know how those sound to you after that we can go ahead and merge the PR
CC: @pradeepnschrodinger

@daniela-mateescu
Copy link
Contributor Author

hi @daniela-mateescu thanks a lot for the PR as well. The approach seems correct but i have some suggestions, let me know how those sound to you after that we can go ahead and merge the PR CC: @pradeepnschrodinger

Thank you! I have done the changes according to your suggestions

Copy link
Collaborator

@karry08 karry08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@karry08 karry08 merged commit a48b962 into schrodinger:master Nov 8, 2023
3 checks passed
@karry08
Copy link
Collaborator

karry08 commented Nov 8, 2023

This is fixed with v2.0.2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resize line not shown when "maxHeight" is set.
4 participants