Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resize cell indicator not showing when maxHeight #703

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/api/apiData.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,16 @@
*/
import columnWidths from '../selectors/columnWidths';
import shallowEqualSelector from '../helper/shallowEqualSelector';
import tableHeightsSelector from '../selectors/tableHeights';

const getApiDataSelector = () =>
shallowEqualSelector(
[
(state) => state.tableSize.height,
(state) =>
(state.headerHeight ? state.headerHeight : 0) +
(state.groupHeaderHeight ? state.groupHeaderHeight : 0) +
tableHeightsSelector(state).visibleRowsHeight,
karry08 marked this conversation as resolved.
Show resolved Hide resolved
(state) => state.elementHeights.groupHeaderHeight,
(state) => state.scrollX,
(state) => state.maxScrollX,
Expand All @@ -22,6 +27,7 @@ const getApiDataSelector = () =>
],
(
/*number*/ tableHeight,
/*number*/ bodyAndHeaderHeight,
karry08 marked this conversation as resolved.
Show resolved Hide resolved
/*number*/ groupHeaderHeight,
/*number*/ scrollX,
/*number*/ maxScrollX,
Expand All @@ -30,6 +36,7 @@ const getApiDataSelector = () =>
) => {
return {
tableHeight,
bodyAndHeaderHeight,
groupHeaderHeight,
scrollX,
maxScrollX,
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/ResizeReorder/ResizeCell.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class ResizeCell extends React.PureComponent {
<>
<ResizerKnob
height={this.props.height}
resizerLineHeight={this.context.tableHeight}
resizerLineHeight={this.context.bodyAndHeaderHeight}
onColumnResizeEnd={this.props.onColumnResizeEnd}
width={this.props.width}
minWidth={this.props.minWidth}
Expand Down