New origin: Atlassian Cloud #25
Conversation
| let groups = []; | ||
| let users = new Map(); | ||
|
|
||
| // Since Atlassian does not have a proper API for listing all |
There was a problem hiding this comment.
This reads like an accidental copy of the comment in getJiraData() :) At this point in the source an attentive reader of the code already knows Atlassian API is wonky so you can skip to the just one short sentences saying that we simply iterate through all groups and then pull every user from that group.
| // "incomplete" page. | ||
| let index = 0; | ||
|
|
||
| while (true) { |
There was a problem hiding this comment.
We already have almost identical code on line 48, I would suggest we move this kind of pagination in a separate function. And perhaps we shouldn't do ad-hoc pagination here at all since https://developer.atlassian.com/cloud/confluence/rest/#api-group-get has pagination information in response.
|
|
||
| for(const groupName of groups ) { | ||
| let index = 0; | ||
| while (true) { |
|
Since the pull request is merged I'd prefer to have a separate pull request addressing my comments. |
No description provided.