Support multiple network ids and network names

[sue445]

CloudStack network_ids can accept multiple values. But vagrant-cloudstack plugin can not use multiple network_ids (only single network_id).

So I added feature for multiple network ids

Usage

Vagrantfile

Vagrant.configure(2) do |config|
  config.vm.provider :cloudstack do |cloudstack, override|
    # single network id
    cloudstack.network_id = "AAAAA"

    # multiple network ids
    cloudstack.network_id = ["AAA", "BBB"]
  end
end

[bheuvel]

@sue445 Nice one! But if we do multiple networks by network_id, we should also allow that via network_name

[sue445]

@bheuvel I pushed fixes. Please review again 🙇

[bheuvel]

Perhaps you can move this new code block (lines 37-49) to the sanitize_domain_config?

[bheuvel]

It's looking good! But I will need to have a closer look later on, so some comments after a quick look:

We may need to support either IDs OR Names and not both at the same time.
This may become a problem is someone would specify IDs id1 id2 and names name3 name2 name1. Due to the sync having a "preference" for IDs, the resulting sync would have id1 id2 id1.

I would suggest to keep it simple and use IDs if present, and only use names if IDs are not present.
So basically @domain_config.network_name = [] unless @domain_config.network_id.nil?
(which could also go into the sanitize_domain_config)
That would also simplify the create_list (and drop the self.?)

[sue445]

I would suggest to keep it simple and use IDs if present, and only use names if IDs are not present.

@bheuvel I fix and push.

[bheuvel]

@sue445 All tests passing, did some "manual" testing with multiple network names/ids, and is looking good! Thanks!

[sue445]

😃