Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Test-Utils #55

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Test-Utils #55

merged 2 commits into from
Jul 30, 2018

Conversation

frederike-ramin
Copy link
Contributor

No description provided.

@frederike-ramin frederike-ramin mentioned this pull request Jul 7, 2018
Merged
cmfcmf
cmfcmf approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@cmfcmf cmfcmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍 Obviously this should be merged only after your 'increase coverage' PR is merged.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 36

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.254%
Totals Coverage Status
Change from base Build 34: 0.0%
Covered Lines: 258
Relevant Lines: 262
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 36

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.254%
Totals Coverage Status
Change from base Build 34: 0.0%
Covered Lines: 258
Relevant Lines: 262
💛 - Coveralls

corinnaj
corinnaj approved these changes Jul 21, 2018
View reviewed changes
Copy link
Contributor

@corinnaj corinnaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing I can think of that we might want to remove variables for eventName, because they are kinda redundant. But that's not really related to your PR anyways.

@frederike-ramin frederike-ramin merged commit 9092fe8 into master Jul 30, 2018
@frederike-ramin frederike-ramin deleted the test-utils branch July 30, 2018 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmfcmf cmfcmf cmfcmf approved these changes

@corinnaj corinnaj corinnaj approved these changes

@GoesOnTangents GoesOnTangents Awaiting requested review from GoesOnTangents

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frederike-ramin @coveralls @cmfcmf @corinnaj