Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge security updates #346

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

primeos-work
Copy link
Member

@primeos-work primeos-work commented Feb 19, 2024

This fixes all current security issues that dependabot reported.
It replaces #338 and #344 (those PRs would be fine too but I prefer mentioning the security fixes in the commit messages - I'll check if the dependabot behavior can be configured to better mark security fixes).

This fixes the RUSTSEC-2024-0003 [0] security issue: "Resource
exhaustion vulnerability in h2 may lead to Denial of Service (DoS)".
See also GHSA-8r5v-vm4m-4g25 and [1].

[0]: https://rustsec.org/advisories/RUSTSEC-2024-0003.html
[1]: https://github.com/science-computing/butido/security/dependabot/12

Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
This fixes the RUSTSEC-2024-0013 [0] security issue: "Memory corruption,
denial of service, and arbitrary code execution in libgit2".
See also GHSA-22q8-ghmq-63vf and [1].

[0]: https://rustsec.org/advisories/RUSTSEC-2024-0013.html
[1]: https://github.com/science-computing/butido/security/dependabot/13

Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
@primeos-work primeos-work added this pull request to the merge queue Feb 19, 2024
Merged via the queue into science-computing:master with commit bd3baad Feb 19, 2024
13 checks passed
@primeos-work
Copy link
Member Author

Hm, it looks GitHub noticed that the two dependabot security alerts are fixed now but somehow GitHub doesn't make the association to this PR (yet?)...

Maybe it's better to merge the dependabot PRs then.
IMO it would be nice to indicated security fixes both in commit messages and via the GitHub UI to make the process as transparent as possible (IMO secrecy only makes sense before merging the fixes - in the case of butido).

@primeos-work primeos-work added the security PRs with security fixes (or related issues) label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security PRs with security fixes (or related issues)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant