Test and improve the merging of package configuration patches #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test to ensure the additional logic for handling/merging the
patches
value (array) inpkg.toml
works correctly, simplifies the code (especially to make it more readable / easier to understand), and fixes a bug (minor as it's a special case).Edit: The bugfix could be considered a bit of a breaking change but I consider it self-documenting as it results in a easy to understand error message if invalid (non-existent) patches are specified, e.g. (I added the
pkg.toml
file path to the output):