docs: Update binary projects recommendation to scikit-build #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
matthewfeickert
commented
Sep 8, 2023
matthewfeickert
commented
- Recommend scikit-build-core + pybind11.
* Recommend scikit-build-core + pybind11.
|
@henryiii this is ready for review, given informal chats. |
matthewfeickert
commented
Sep 8, 2023
| @@ -65,7 +65,8 @@ During generation you can select from the following backends for your package: | |||
| versioning) **(Recommended for Rust projects)** | |||
|
|
|||
| Currently, the best choice is probably hatch for pure Python projects, and | |||
| setuptools (such as the pybind11 choice) for binary projects. | |||
| scikit-build (such as the scikit-build-core + pybind11 choice) for binary | |||
There was a problem hiding this comment.
Giving scikit-build here instead of explicitly scikit-build-core given that scikit-build-core isn't a listed top level option.
henryiii
approved these changes
Sep 8, 2023
|
@henryiii I don't have permissions to merge PRs to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.