Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: (getstarted.md) Update instructions #401

Conversation

alphapapa
Copy link
Contributor

See #397.

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 96d34c1
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/654d295696bda8000950aa76
😎 Deploy Preview https://deploy-preview-401--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@alphapapa alphapapa mentioned this pull request Nov 8, 2023
18 tasks
Copy link
Member

@stefanv stefanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Adam. This still needs instructions on how to install dart-sass.

doc/content/getstarted.md Outdated Show resolved Hide resolved
doc/content/getstarted.md Outdated Show resolved Hide resolved
doc/content/getstarted.md Outdated Show resolved Hide resolved
doc/content/getstarted.md Outdated Show resolved Hide resolved
doc/content/getstarted.md Outdated Show resolved Hide resolved
doc/content/getstarted.md Outdated Show resolved Hide resolved
doc/content/getstarted.md Outdated Show resolved Hide resolved
@jarrodmillman jarrodmillman added the type: Documentation Improvements or additions to documentation label Nov 8, 2023
@jarrodmillman
Copy link
Member

We should explain that folks need to install dart-sass. It is an optional dependency for hugo.

@alphapapa alphapapa force-pushed the wip/397-update-installation-instructions branch from 31b36ba to 4295d93 Compare November 9, 2023 17:48
alphapapa and others added 3 commits November 9, 2023 11:58
Co-authored-by: Stefan van der Walt <stefanv@berkeley.edu>
Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
Hugo's guide seems comprehensive and well-written, so we link to it.
Co-authored-by: Stefan van der Walt <stefanv@berkeley.edu>
@alphapapa
Copy link
Contributor Author

alphapapa commented Nov 9, 2023

Thanks, Adam. This still needs instructions on how to install dart-sass.

We should explain that folks need to install dart-sass. It is an optional dependency for hugo.

Right. I've added a section about that in this commit: 8f508ce Hugo's own instructions for installing Dart Sass seem excellent, so I just linked to them. But if you'd like to do something else, please let me know.

@alphapapa alphapapa self-assigned this Nov 9, 2023
@alphapapa alphapapa added this to the 0.5 milestone Nov 9, 2023
@jarrodmillman
Copy link
Member

pre-commit.ci autofix

@jarrodmillman jarrodmillman merged commit cba8f23 into scientific-python:main Nov 9, 2023
6 checks passed
@alphapapa alphapapa deleted the wip/397-update-installation-instructions branch November 9, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants