Add dark mode theme to website #139

Bashamega · 2024-05-04T15:44:17Z

Solves #138
Hello:)
I have added the dark mode theme
Changes Made:

Add the gitpod file for gitpod users
Updated the theme
Changes the Shore codes
ScreenShot:

netlify · 2024-05-04T15:44:31Z

❌ Deploy Preview for pybamm-developer-preview failed.

Name	Link
🔨 Latest commit	`4212d99`
🔍 Latest deploy log	https://app.netlify.com/sites/pybamm-developer-preview/deploys/663657d25d63e30008d812f1

netlify · 2024-05-04T15:45:17Z

✅ Deploy Preview for pybamm-developer-preview ready!

Name	Link
🔨 Latest commit	`d848d8f`
🔍 Latest deploy log	https://app.netlify.com/sites/pybamm-developer-preview/deploys/66390ee37beb820008091702
😎 Deploy Preview	https://deploy-preview-139--pybamm-developer-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

agriyakhetarpal · 2024-05-04T16:47:44Z

Build logs

9:14:24 PM: Waiting for other deploys from your team to complete. Check the queue: https://app.netlify.com/teams/pybamm/builds
9:15:16 PM: build-image version: 3d3c7e8b4321e2c1a54a2c4584fb46ba742b1630 (focal)
9:15:16 PM: buildbot version: d85d718afb4cfc1d31fb4837470daa2b526f928f
9:15:16 PM: Fetching cached dependencies
9:15:16 PM: Starting to download cache of 655.9MB
9:15:18 PM: Finished downloading cache in 2.065s
9:15:18 PM: Starting to extract cache
9:15:25 PM: Finished extracting cache in 6.413s
9:15:25 PM: Finished fetching cache in 8.545s
9:15:25 PM: Starting to prepare the repo for build
9:15:25 PM: Preparing Git Reference pull/139/head
9:15:27 PM: Custom ignore command detected. Proceeding with the specified command: 'false'
9:15:27 PM: manpath: warning: $PATH not set
9:15:28 PM: Starting to install dependencies
9:15:28 PM: Python version set to 3.8
9:15:28 PM: Attempting Ruby version 2.7.2, read from environment
9:15:29 PM: Using Ruby version 2.7.2
9:15:29 PM: Started restoring cached go cache
9:15:29 PM: Finished restoring cached go cache
9:15:30 PM: go version go1.19.13 linux/amd64
9:15:31 PM: Using PHP version 8.0
9:15:31 PM: Installing Hugo 0.121.2
9:15:31 PM: hugo v0.121.2-6d5b44305eaa9d0a157946492a6f319da38de154+extended linux/amd64 BuildDate=2024-01-05T12:21:15Z VendorInfo=gohugoio
9:15:32 PM: Started restoring cached Node.js version
9:15:36 PM: Finished restoring cached Node.js version
9:15:36 PM: v20.12.2 is already installed.
9:15:37 PM: Now using node v20.12.2 (npm v10.5.0)
9:15:37 PM: Enabling Node.js Corepack
9:15:37 PM: Started restoring cached build plugins
9:15:37 PM: Finished restoring cached build plugins
9:15:37 PM: Successfully installed dependencies
9:15:37 PM: Starting build script
9:15:38 PM: Detected 1 framework(s)
9:15:38 PM: "hugo" at version "unknown"
9:15:38 PM: Section completed: initializing
9:15:40 PM: 
9:15:40 PM: Netlify Build                                                 
9:15:40 PM: ────────────────────────────────────────────────────────────────
9:15:40 PM: 
9:15:40 PM: ❯ Version
9:15:40 PM:   @netlify/build 29.41.1
9:15:40 PM: 
9:15:40 PM: ❯ Flags
9:15:40 PM:   baseRelDir: true
9:15:40 PM:   buildId: 663657d879400d0008fb65d7
9:15:40 PM:   deployId: 663657d879400d0008fb65d9
9:15:40 PM: 
9:15:40 PM: ❯ Current directory
9:15:40 PM:   /opt/build/repo
9:15:40 PM: 
9:15:40 PM: ❯ Config file
9:15:40 PM:   /opt/build/repo/netlify.toml
9:15:40 PM: 
9:15:40 PM: ❯ Context
9:15:40 PM:   deploy-preview
9:15:40 PM: 
9:15:40 PM: ❯ Loading plugins
9:15:40 PM:    - netlify-plugin-checklinks@4.1.1 from netlify.toml
9:15:40 PM:    - @netlify/plugin-lighthouse@4.0.7 from netlify.toml
9:15:40 PM: 
9:15:40 PM: ❯ Outdated plugins
9:15:40 PM:    - @netlify/plugin-lighthouse@4.0.7: latest version is 6.0.0
9:15:40 PM:      To upgrade this plugin, please remove it from "netlify.toml" and install it from the Netlify plugins directory instead (https://app.netlify.com/plugins)
9:15:42 PM: 
9:15:42 PM: Build command from Netlify app                                
9:15:42 PM: ────────────────────────────────────────────────────────────────
9:15:42 PM: 
9:15:42 PM: $ hugo
9:15:42 PM: Start building sites …
9:15:42 PM: hugo v0.121.2-6d5b44305eaa9d0a157946492a6f319da38de154+extended linux/amd64 BuildDate=2024-01-05T12:21:15Z VendorInfo=gohugoio
9:15:42 PM: ERROR TOCSS-DART: failed to transform "theme-css/pst/bootstrap.scss.css" (text/x-scss). You need dart-sass-embedded in your system $PATH.: this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information
9:15:42 PM: ERROR TOCSS-DART: failed to transform "theme-css/pst/pydata-sphinx-theme.scss.css" (text/x-scss). You need dart-sass-embedded in your system $PATH.: this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information
9:15:42 PM: ERROR TOCSS-DART: failed to transform "theme-css/spht/index.scss.css" (text/x-scss). You need dart-sass-embedded in your system $PATH.: this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information
9:15:42 PM: Total in 129 ms
9:15:42 PM: Error: error building site: TOCSS-DART: failed to transform "theme-css/sphinx-design/index.scss.css" (text/x-scss). You need dart-sass-embedded in your system $PATH.: this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information
9:15:43 PM: 
9:15:43 PM: "build.command" failed                                        
9:15:43 PM: ────────────────────────────────────────────────────────────────
9:15:43 PM: 
9:15:43 PM:   Error message
9:15:43 PM:   Command failed with exit code 1: hugo (https://ntl.fyi/exit-code-1)
9:15:43 PM: 
9:15:43 PM:   Error location
9:15:43 PM:   In Build command from Netlify app:
9:15:43 PM:   hugo
9:15:43 PM: 
9:15:43 PM:   Resolved config
9:15:43 PM:   build:
9:15:43 PM:     command: hugo
9:15:43 PM:     commandOrigin: ui
9:15:43 PM:     environment:
9:15:43 PM:       - REVIEW_ID
9:15:43 PM:       - PYTHON_VERSION
9:15:43 PM:       - HUGO_VERSION
9:15:43 PM:     ignore: 'false'
9:15:43 PM:     publish: /opt/build/repo/public
9:15:43 PM:     publishOrigin: ui
9:15:43 PM:   plugins:
9:15:43 PM:     - inputs:
9:15:43 PM:         checkExternal: false
9:15:43 PM:         recursive: true
9:15:43 PM:       origin: config
9:15:43 PM:       package: netlify-plugin-checklinks
9:15:43 PM:     - inputs: {}
9:15:43 PM:       origin: config
9:15:43 PM:       package: '@netlify/plugin-lighthouse'
9:15:43 PM:   redirects:
9:15:43 PM:     - from: /benchmarks
9:15:43 PM:       status: 301
9:15:43 PM:       to: https://pybamm-team.github.io/pybamm-bench/
9:15:43 PM:     - from: /slack
9:15:43 PM:       status: 301
9:15:43 PM:       to: https://join.slack.com/t/pybamm/shared_invite/zt-1xwnvkqrb-6ZKgB8yBU3zuzH91USdv_A
9:15:44 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
9:15:44 PM:     - from: /*
      status: 404
      to: /404/
  redirectsOrigin: config
9:15:44 PM: Build failed due to a user error: Build script returned non-zero exit code: 2
9:15:44 PM: Failing build: Failed to build site
9:15:44 PM: Finished processing build request in 27.847s

I think we need to bump the Hugo version. What does the theme website use?

agriyakhetarpal

Thank you for starting this, @Bashamega. I think I will be able to better review this when the deployment to Netlify passes. I'll start checking locally in the meantime.

The GitPod configuration is pretty useful to have. However, could you please add that (plus instructions on how to set it up and use it) in a separate PR, since it's not related to the theme update?

agriyakhetarpal · 2024-05-04T17:03:00Z

I just checked and the theme now requires dart-sass to be installed alongside Hugo: https://gohugo.io/hugo-pipes/transpile-sass-to-css/#dart-sass. The change was documented in scientific-python/scientific-python-hugo-theme#401.

agriyakhetarpal · 2024-05-04T17:06:37Z

They have some custom build commands here about how to install it: https://github.com/scientific-python/scientific-python-hugo-theme/blob/fa5570b57c22812b511c091f63d29fc125e00747/doc/netlify.toml#L2 and https://gohugo.io/hugo-pipes/transpile-sass-to-css/#netlify

Bashamega · 2024-05-05T03:27:51Z

Sure @agriyakhetarpal, I have read all your comments and I will update the Hugo theme and add the dart package in the Netlify.

Bashamega · 2024-05-05T03:36:54Z

I have updated the packages in the netlify.toml. I couldn't open a new pr since i forgot to create a new branch

agriyakhetarpal · 2024-05-05T08:44:54Z

I don't see the dart-sass installation in the Netlify configuration file as of now, could you please add it?

Here are the latest build logs:

Tap to expand

9:04:53 AM: build-image version: 3d3c7e8b4321e2c1a54a2c4584fb46ba742b1630 (focal)
9:04:53 AM: buildbot version: d85d718afb4cfc1d31fb4837470daa2b526f928f
9:04:53 AM: Fetching cached dependencies
9:04:53 AM: Starting to download cache of 655.9MB
9:05:00 AM: Finished downloading cache in 6.973s
9:05:00 AM: Starting to extract cache
9:05:06 AM: Finished extracting cache in 6.552s
9:05:07 AM: Finished fetching cache in 13.608s
9:05:07 AM: Starting to prepare the repo for build
9:05:07 AM: Preparing Git Reference pull/139/head
9:05:08 AM: Custom ignore command detected. Proceeding with the specified command: 'false'
9:05:09 AM: manpath: warning: $PATH not set
9:05:09 AM: Starting to install dependencies
9:05:09 AM: Python version set to 3.8
9:05:10 AM: Attempting Ruby version 2.7.2, read from environment
9:05:10 AM: Using Ruby version 2.7.2
9:05:11 AM: Started restoring cached go cache
9:05:11 AM: Finished restoring cached go cache
9:05:12 AM: go version go1.19.13 linux/amd64
9:05:13 AM: Using PHP version 8.0
9:05:13 AM: Installing Hugo 0.125.4
9:05:17 AM: hugo v0.125.4-cc3574ef4f41fccbe88d9443ed066eb10867ada2+extended linux/amd64 BuildDate=2024-04-25T13:27:26Z VendorInfo=gohugoio
9:05:18 AM: Started restoring cached Node.js version
9:05:21 AM: Finished restoring cached Node.js version
9:05:22 AM: v20.12.2 is already installed.
9:05:22 AM: Now using node v20.12.2 (npm v10.5.0)
9:05:22 AM: Enabling Node.js Corepack
9:05:22 AM: Started restoring cached build plugins
9:05:22 AM: Finished restoring cached build plugins
9:05:22 AM: Successfully installed dependencies
9:05:22 AM: Starting build script
9:05:23 AM: Detected 1 framework(s)
9:05:23 AM: "hugo" at version "unknown"
9:05:23 AM: Section completed: initializing
9:05:25 AM: 
9:05:25 AM: Netlify Build                                                 
9:05:25 AM: ────────────────────────────────────────────────────────────────
9:05:25 AM: 
9:05:25 AM: ❯ Version
9:05:25 AM:   @netlify/build 29.41.1
9:05:25 AM: 
9:05:25 AM: ❯ Flags
9:05:25 AM:   baseRelDir: true
9:05:25 AM:   buildId: 6636fe513882e800086c0cab
9:05:25 AM:   deployId: 6636fe513882e800086c0cad
9:05:25 AM: 
9:05:25 AM: ❯ Current directory
9:05:25 AM:   /opt/build/repo
9:05:25 AM: 
9:05:25 AM: ❯ Config file
9:05:25 AM:   /opt/build/repo/netlify.toml
9:05:25 AM: 
9:05:25 AM: ❯ Context
9:05:25 AM:   deploy-preview
9:05:25 AM: 
9:05:25 AM: ❯ Loading plugins
9:05:25 AM:    - netlify-plugin-checklinks@4.1.1 from netlify.toml
9:05:25 AM:    - @netlify/plugin-lighthouse@4.0.7 from netlify.toml
9:05:25 AM: 
9:05:25 AM: ❯ Outdated plugins
9:05:25 AM:    - @netlify/plugin-lighthouse@4.0.7: latest version is 6.0.0
9:05:25 AM:      To upgrade this plugin, please remove it from "netlify.toml" and install it from the Netlify plugins directory instead (https://app.netlify.com/plugins)
9:05:27 AM: 
9:05:27 AM: Build command from Netlify app                                
9:05:27 AM: ────────────────────────────────────────────────────────────────
9:05:27 AM: 
9:05:27 AM: $ hugo
9:05:27 AM: Start building sites …
9:05:27 AM: hugo v0.125.4-cc3574ef4f41fccbe88d9443ed066eb10867ada2+extended linux/amd64 BuildDate=2024-04-25T13:27:26Z VendorInfo=gohugoio
9:05:27 AM: ERROR TOCSS-DART: failed to transform "theme-css/sphinx-design/index.scss.css" (text/x-scss). You need dart-sass-embedded in your system $PATH.: this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information
9:05:27 AM: Total in 85 ms
9:05:27 AM: Error: error building site: TOCSS-DART: failed to transform "theme-css/sphinx-design/index.scss.css" (text/x-scss). You need dart-sass-embedded in your system $PATH.: this feature is not available in your current Hugo version, see https://goo.gl/YMrWcn for more information
9:05:28 AM: 
9:05:28 AM: "build.command" failed                                        
9:05:28 AM: ────────────────────────────────────────────────────────────────
9:05:28 AM: 
9:05:28 AM:   Error message
9:05:28 AM:   Command failed with exit code 1: hugo (https://ntl.fyi/exit-code-1)
9:05:28 AM: 
9:05:28 AM:   Error location
9:05:28 AM:   In Build command from Netlify app:
9:05:28 AM:   hugo
9:05:28 AM: 
9:05:28 AM:   Resolved config
9:05:28 AM:   build:
9:05:28 AM:     command: hugo
9:05:28 AM:     commandOrigin: ui
9:05:28 AM:     environment:
9:05:28 AM:       - REVIEW_ID
9:05:28 AM:       - PYTHON_VERSION
9:05:28 AM:       - HUGO_VERSION
9:05:28 AM:       - DART_SASS_VERSION
9:05:28 AM:       - DART_SASS_URL
9:05:28 AM:     ignore: 'false'
9:05:28 AM:     publish: /opt/build/repo/public
9:05:28 AM:     publishOrigin: ui
9:05:28 AM:   plugins:
9:05:28 AM:     - inputs:
9:05:28 AM:         checkExternal: false
9:05:28 AM:         recursive: true
9:05:28 AM:       origin: config
9:05:28 AM:       package: netlify-plugin-checklinks
9:05:28 AM:     - inputs: {}
9:05:28 AM:       origin: config
9:05:28 AM:       package: '@netlify/plugin-lighthouse'
9:05:28 AM:   redirects:
9:05:28 AM:     - from: /benchmarks
9:05:28 AM:       status: 301
9:05:28 AM:       to: https://pybamm-team.github.io/pybamm-bench/
9:05:28 AM:     - from: /slack
9:05:28 AM:       status: 301
9:05:28 AM:       to: https://join.slack.com/t/pybamm/shared_invite/zt-1xwnvkqrb-6ZKgB8yBU3zuzH91USdv_A
9:05:28 AM:     - from: /*
      status: 404
      to: /404/
  redirectsOrigin: config
9:05:28 AM: Build failed due to a user error: Build script returned non-zero exit code: 2
9:05:28 AM: Failing build: Failed to build site
9:05:29 AM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
9:05:29 AM: Finished processing build request in 35.916s

Bashamega · 2024-05-05T12:08:09Z

I don't see the dart-sass installation in the Netlify configuration file as of now, could you please add it?

Here are the latest build logs:

Tap to expand

It should be working.

If i have added incorrectly please tell me what should a put or request a change.

agriyakhetarpal · 2024-05-05T12:15:36Z

It should be working.

You will need to install dart-sass as well, by customising the build. There might be a few differences between the paths where the websites and the built files are stored.

Bashamega · 2024-05-05T12:22:05Z

It should be working.

You will need to install dart-sass as well, by customising the build. There might be a few differences between the paths where the websites and the built files are stored.

Where is the build files stored?

agriyakhetarpal · 2024-05-05T12:39:00Z

Where is the build files stored?

In our case, they are stored in public/, and built from the root directory.

Bashamega · 2024-05-05T12:43:11Z

Where is the build files stored?

In our case, they are stored in public/, and built from the root directory.

It should be fixed now

agriyakhetarpal · 2024-05-05T13:58:43Z

I think it will be fixed when the Netlify checks are all green:

Newest deployment logs

6:12:39 PM: Waiting for other deploys from your team to complete. Check the queue: https://app.netlify.com/teams/pybamm/builds
6:13:28 PM: build-image version: 3d3c7e8b4321e2c1a54a2c4584fb46ba742b1630 (focal)
6:13:28 PM: buildbot version: d85d718afb4cfc1d31fb4837470daa2b526f928f
6:13:29 PM: Fetching cached dependencies
6:13:29 PM: Starting to download cache of 655.9MB
6:13:31 PM: Finished downloading cache in 2.169s
6:13:31 PM: Starting to extract cache
6:13:37 PM: Finished extracting cache in 5.923s
6:13:37 PM: Finished fetching cache in 8.182s
6:13:37 PM: Starting to prepare the repo for build
6:13:37 PM: Preparing Git Reference pull/139/head
6:13:38 PM: Custom build path detected. Proceeding with the specified path: 'content'
6:13:38 PM: Custom publish path detected. Proceeding with the specified path: 'content/public'
6:13:38 PM: Custom build command detected. Proceeding with the specified command: 'export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET})
    '
6:13:38 PM: Custom ignore command detected. Proceeding with the specified command: 'false'
6:13:39 PM: manpath: warning: $PATH not set
6:13:39 PM: Starting to install dependencies
6:13:40 PM: Python version set to 3.8
6:13:40 PM: Attempting Ruby version 2.7.2, read from environment
6:13:40 PM: Using Ruby version 2.7.2
6:13:41 PM: Started restoring cached go cache
6:13:41 PM: Finished restoring cached go cache
6:13:42 PM: go version go1.19.13 linux/amd64
6:13:43 PM: Using PHP version 8.0
6:13:43 PM: Installing Hugo 0.125.4
6:13:44 PM: hugo v0.125.4-cc3574ef4f41fccbe88d9443ed066eb10867ada2+extended linux/amd64 BuildDate=2024-04-25T13:27:26Z VendorInfo=gohugoio
6:13:45 PM: Started restoring cached Node.js version
6:13:49 PM: Finished restoring cached Node.js version
6:13:49 PM: v20.12.2 is already installed.
6:13:49 PM: Now using node v20.12.2 (npm v10.5.0)
6:13:49 PM: Enabling Node.js Corepack
6:13:49 PM: Started restoring cached build plugins
6:13:49 PM: Finished restoring cached build plugins
6:13:50 PM: Successfully installed dependencies
6:13:50 PM: Starting build script
6:13:51 PM: Detected 1 framework(s)
6:13:51 PM: "hugo" at version "unknown"
6:13:51 PM: Section completed: initializing
6:13:52 PM: 
6:13:52 PM: Netlify Build                                                 
6:13:52 PM: ────────────────────────────────────────────────────────────────
6:13:52 PM: 
6:13:52 PM: ❯ Version
6:13:52 PM:   @netlify/build 29.41.1
6:13:52 PM: 
6:13:52 PM: ❯ Flags
6:13:52 PM:   baseRelDir: true
6:13:52 PM:   buildId: 66377ebe7fde460008b80851
6:13:52 PM:   deployId: 66377ebe7fde460008b80853
6:13:52 PM: 
6:13:52 PM: ❯ Current directory
6:13:52 PM:   /opt/build/repo/content
6:13:52 PM: 
6:13:52 PM: ❯ Config file
6:13:52 PM:   /opt/build/repo/netlify.toml
6:13:52 PM: 
6:13:52 PM: ❯ Context
6:13:52 PM:   deploy-preview
6:13:52 PM: 
6:13:52 PM: ❯ Loading plugins
6:13:52 PM:    - netlify-plugin-checklinks@4.1.1 from netlify.toml
6:13:52 PM:    - @netlify/plugin-lighthouse@4.0.7 from netlify.toml
6:13:52 PM: 
6:13:52 PM: ❯ Outdated plugins
6:13:52 PM:    - @netlify/plugin-lighthouse@4.0.7: latest version is 6.0.0
6:13:52 PM:      To upgrade this plugin, please remove it from "netlify.toml" and install it from the Netlify plugins directory instead (https://app.netlify.com/plugins)
6:13:54 PM: 
6:13:54 PM: build.command from netlify.toml                               
6:13:54 PM: ────────────────────────────────────────────────────────────────
6:13:54 PM: 
6:13:54 PM: $ export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET})
6:13:54 PM:     
6:13:54 PM:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
6:13:54 PM:                                  Dload  Upload   Total   Spent    Left  Speed
6:13:54 PM:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
6:13:54 PM:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
6:13:54 PM: 100 3671k  100 3671k    0     0  15.3M      0 --:--:-- --:--:-- --:--:-- 15.3M
6:13:54 PM: curl: Saved to filename 'dart-sass-1.75.0-linux-x64.tar.gz'
6:13:55 PM: make: *** No targets specified and no makefile found.  Stop.
6:13:56 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
6:13:56 PM: 
6:13:56 PM: "build.command" failed                                        
6:13:56 PM: ────────────────────────────────────────────────────────────────
6:13:56 PM: 
6:13:56 PM:   Error message
6:13:56 PM:   Command failed with exit code 2: export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET}) (https://ntl.fyi/exit-code-2)
6:13:56 PM: 
6:13:56 PM:   Error location
6:13:56 PM:   In build.command from netlify.toml:
6:13:56 PM:   export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET})
6:13:56 PM: 
6:13:56 PM:   Resolved config
6:13:56 PM:   build:
6:13:56 PM:     base: /opt/build/repo/content
6:13:56 PM:     command: |-
6:13:56 PM:       export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET})
6:13:56 PM: 
6:13:56 PM:     commandOrigin: config
6:13:56 PM:     environment:
6:13:56 PM:       - REVIEW_ID
6:13:56 PM:       - PYTHON_VERSION
6:13:56 PM:       - HUGO_VERSION
6:13:56 PM:       - DART_SASS_VERSION
6:13:56 PM:       - DART_SASS_URL
6:13:56 PM:     ignore: 'false'
6:13:56 PM:     publish: /opt/build/repo/content/public
6:13:56 PM:     publishOrigin: config
6:13:56 PM:   plugins:
6:13:56 PM:     - inputs:
6:13:56 PM:         checkExternal: false
6:13:56 PM:         recursive: true
6:13:56 PM:       origin: config
6:13:56 PM:       package: netlify-plugin-checklinks
6:13:56 PM:     - inputs: {}
6:13:56 PM:       origin: config
6:13:56 PM:       package: '@netlify/plugin-lighthouse'
6:13:56 PM:   redirects:
6:13:56 PM:     - from: /benchmarks
6:13:56 PM:       status: 301
6:13:56 PM:       to: https://pybamm-team.github.io/pybamm-bench/
6:13:56 PM:     - from: /slack
6:13:56 PM:       status: 301
6:13:56 PM:       to: https://join.slack.com/t/pybamm/shared_invite/zt-1xwnvkqrb-6ZKgB8yBU3zuzH91USdv_A
6:13:56 PM:     - from: /*
      status: 404
      to: /404/
  redirectsOrigin: config
6:13:56 PM: Build failed due to a user error: Build script returned non-zero exit code: 2
6:13:56 PM: Failing build: Failed to build site
6:13:56 PM: Finished processing build request in 27.895s

netlify.toml

Bashamega · 2024-05-05T14:04:54Z

I think it will be fixed when the Netlify checks are all green:

Newest deployment logs

6:12:39 PM: Waiting for other deploys from your team to complete. Check the queue: https://app.netlify.com/teams/pybamm/builds
6:13:28 PM: build-image version: 3d3c7e8b4321e2c1a54a2c4584fb46ba742b1630 (focal)
6:13:28 PM: buildbot version: d85d718afb4cfc1d31fb4837470daa2b526f928f
6:13:29 PM: Fetching cached dependencies
6:13:29 PM: Starting to download cache of 655.9MB
6:13:31 PM: Finished downloading cache in 2.169s
6:13:31 PM: Starting to extract cache
6:13:37 PM: Finished extracting cache in 5.923s
6:13:37 PM: Finished fetching cache in 8.182s
6:13:37 PM: Starting to prepare the repo for build
6:13:37 PM: Preparing Git Reference pull/139/head
6:13:38 PM: Custom build path detected. Proceeding with the specified path: 'content'
6:13:38 PM: Custom publish path detected. Proceeding with the specified path: 'content/public'
6:13:38 PM: Custom build command detected. Proceeding with the specified command: 'export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET})
    '
6:13:38 PM: Custom ignore command detected. Proceeding with the specified command: 'false'
6:13:39 PM: manpath: warning: $PATH not set
6:13:39 PM: Starting to install dependencies
6:13:40 PM: Python version set to 3.8
6:13:40 PM: Attempting Ruby version 2.7.2, read from environment
6:13:40 PM: Using Ruby version 2.7.2
6:13:41 PM: Started restoring cached go cache
6:13:41 PM: Finished restoring cached go cache
6:13:42 PM: go version go1.19.13 linux/amd64
6:13:43 PM: Using PHP version 8.0
6:13:43 PM: Installing Hugo 0.125.4
6:13:44 PM: hugo v0.125.4-cc3574ef4f41fccbe88d9443ed066eb10867ada2+extended linux/amd64 BuildDate=2024-04-25T13:27:26Z VendorInfo=gohugoio
6:13:45 PM: Started restoring cached Node.js version
6:13:49 PM: Finished restoring cached Node.js version
6:13:49 PM: v20.12.2 is already installed.
6:13:49 PM: Now using node v20.12.2 (npm v10.5.0)
6:13:49 PM: Enabling Node.js Corepack
6:13:49 PM: Started restoring cached build plugins
6:13:49 PM: Finished restoring cached build plugins
6:13:50 PM: Successfully installed dependencies
6:13:50 PM: Starting build script
6:13:51 PM: Detected 1 framework(s)
6:13:51 PM: "hugo" at version "unknown"
6:13:51 PM: Section completed: initializing
6:13:52 PM: 
6:13:52 PM: Netlify Build                                                 
6:13:52 PM: ────────────────────────────────────────────────────────────────
6:13:52 PM: 
6:13:52 PM: ❯ Version
6:13:52 PM:   @netlify/build 29.41.1
6:13:52 PM: 
6:13:52 PM: ❯ Flags
6:13:52 PM:   baseRelDir: true
6:13:52 PM:   buildId: 66377ebe7fde460008b80851
6:13:52 PM:   deployId: 66377ebe7fde460008b80853
6:13:52 PM: 
6:13:52 PM: ❯ Current directory
6:13:52 PM:   /opt/build/repo/content
6:13:52 PM: 
6:13:52 PM: ❯ Config file
6:13:52 PM:   /opt/build/repo/netlify.toml
6:13:52 PM: 
6:13:52 PM: ❯ Context
6:13:52 PM:   deploy-preview
6:13:52 PM: 
6:13:52 PM: ❯ Loading plugins
6:13:52 PM:    - netlify-plugin-checklinks@4.1.1 from netlify.toml
6:13:52 PM:    - @netlify/plugin-lighthouse@4.0.7 from netlify.toml
6:13:52 PM: 
6:13:52 PM: ❯ Outdated plugins
6:13:52 PM:    - @netlify/plugin-lighthouse@4.0.7: latest version is 6.0.0
6:13:52 PM:      To upgrade this plugin, please remove it from "netlify.toml" and install it from the Netlify plugins directory instead (https://app.netlify.com/plugins)
6:13:54 PM: 
6:13:54 PM: build.command from netlify.toml                               
6:13:54 PM: ────────────────────────────────────────────────────────────────
6:13:54 PM: 
6:13:54 PM: $ export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET})
6:13:54 PM:     
6:13:54 PM:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
6:13:54 PM:                                  Dload  Upload   Total   Spent    Left  Speed
6:13:54 PM:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
6:13:54 PM:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
6:13:54 PM: 100 3671k  100 3671k    0     0  15.3M      0 --:--:-- --:--:-- --:--:-- 15.3M
6:13:54 PM: curl: Saved to filename 'dart-sass-1.75.0-linux-x64.tar.gz'
6:13:55 PM: make: *** No targets specified and no makefile found.  Stop.
6:13:56 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
6:13:56 PM: 
6:13:56 PM: "build.command" failed                                        
6:13:56 PM: ────────────────────────────────────────────────────────────────
6:13:56 PM: 
6:13:56 PM:   Error message
6:13:56 PM:   Command failed with exit code 2: export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET}) (https://ntl.fyi/exit-code-2)
6:13:56 PM: 
6:13:56 PM:   Error location
6:13:56 PM:   In build.command from netlify.toml:
6:13:56 PM:   export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET})
6:13:56 PM: 
6:13:56 PM:   Resolved config
6:13:56 PM:   build:
6:13:56 PM:     base: /opt/build/repo/content
6:13:56 PM:     command: |-
6:13:56 PM:       export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && make ${BUILD_TARGET})
6:13:56 PM: 
6:13:56 PM:     commandOrigin: config
6:13:56 PM:     environment:
6:13:56 PM:       - REVIEW_ID
6:13:56 PM:       - PYTHON_VERSION
6:13:56 PM:       - HUGO_VERSION
6:13:56 PM:       - DART_SASS_VERSION
6:13:56 PM:       - DART_SASS_URL
6:13:56 PM:     ignore: 'false'
6:13:56 PM:     publish: /opt/build/repo/content/public
6:13:56 PM:     publishOrigin: config
6:13:56 PM:   plugins:
6:13:56 PM:     - inputs:
6:13:56 PM:         checkExternal: false
6:13:56 PM:         recursive: true
6:13:56 PM:       origin: config
6:13:56 PM:       package: netlify-plugin-checklinks
6:13:56 PM:     - inputs: {}
6:13:56 PM:       origin: config
6:13:56 PM:       package: '@netlify/plugin-lighthouse'
6:13:56 PM:   redirects:
6:13:56 PM:     - from: /benchmarks
6:13:56 PM:       status: 301
6:13:56 PM:       to: https://pybamm-team.github.io/pybamm-bench/
6:13:56 PM:     - from: /slack
6:13:56 PM:       status: 301
6:13:56 PM:       to: https://join.slack.com/t/pybamm/shared_invite/zt-1xwnvkqrb-6ZKgB8yBU3zuzH91USdv_A
6:13:56 PM:     - from: /*
      status: 404
      to: /404/
  redirectsOrigin: config
6:13:56 PM: Build failed due to a user error: Build script returned non-zero exit code: 2
6:13:56 PM: Failing build: Failed to build site
6:13:56 PM: Finished processing build request in 27.895s

Is there anything else that i can do. If there is nothing that i can do please merge the pr

agriyakhetarpal · 2024-05-05T14:15:11Z

Is there anything else that i can do. If there is nothing that i can do please merge the pr

@Bashamega, I don't think we will be able to merge the PR with failing checks. I am happy to help you resolve them :) We have a bit of custom configuration that you can adapt to, and the rest of the changes should be easier to handle after that. We need to use nox instead of make, due to this line:

6:13:55 PM: make: *** No targets specified and no makefile found.  Stop.

Bashamega · 2024-05-05T14:24:08Z

Is there anything else that i can do. If there is nothing that i can do please merge the pr

@Bashamega, I don't think we will be able to merge the PR with failing checks. I am happy to help you resolve them :) We have a bit of custom configuration that you can adapt to, and the rest of the changes should be easier to handle after that. We need to use nox instead of make, due to this line:
6:13:55 PM: make: *** No targets specified and no makefile found.  Stop.

Thank you very much for the tip. I am going to fix it

Bashamega · 2024-05-05T14:28:29Z

Done. It should be better now

agriyakhetarpal · 2024-05-05T16:17:43Z

Build logs

7:58:18 PM: build-image version: 3d3c7e8b4321e2c1a54a2c4584fb46ba742b1630 (focal)
7:58:18 PM: buildbot version: d85d718afb4cfc1d31fb4837470daa2b526f928f
7:58:18 PM: Fetching cached dependencies
7:58:18 PM: Starting to download cache of 655.9MB
7:58:22 PM: Finished downloading cache in 4.175s
7:58:22 PM: Starting to extract cache
7:58:29 PM: Finished extracting cache in 6.332s
7:58:29 PM: Finished fetching cache in 10.577s
7:58:29 PM: Starting to prepare the repo for build
7:58:29 PM: Preparing Git Reference pull/139/head
7:58:30 PM: Custom build path detected. Proceeding with the specified path: 'content'
7:58:30 PM: Custom publish path detected. Proceeding with the specified path: 'content/public'
7:58:30 PM: Custom build command detected. Proceeding with the specified command: 'export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && nox ${BUILD_TARGET})
    '
7:58:30 PM: Custom ignore command detected. Proceeding with the specified command: 'false'
7:58:31 PM: manpath: warning: $PATH not set
7:58:31 PM: Starting to install dependencies
7:58:32 PM: Python version set to 3.8
7:58:32 PM: Attempting Ruby version 2.7.2, read from environment
7:58:33 PM: Using Ruby version 2.7.2
7:58:33 PM: Started restoring cached go cache
7:58:33 PM: Finished restoring cached go cache
7:58:35 PM: go version go1.19.13 linux/amd64
7:58:36 PM: Using PHP version 8.0
7:58:36 PM: Installing Hugo 0.125.4
7:58:37 PM: hugo v0.125.4-cc3574ef4f41fccbe88d9443ed066eb10867ada2+extended linux/amd64 BuildDate=2024-04-25T13:27:26Z VendorInfo=gohugoio
7:58:38 PM: Started restoring cached Node.js version
7:58:42 PM: Finished restoring cached Node.js version
7:58:42 PM: v20.12.2 is already installed.
7:58:42 PM: Now using node v20.12.2 (npm v10.5.0)
7:58:42 PM: Enabling Node.js Corepack
7:58:42 PM: Started restoring cached build plugins
7:58:42 PM: Finished restoring cached build plugins
7:58:43 PM: Successfully installed dependencies
7:58:43 PM: Starting build script
7:58:44 PM: Detected 1 framework(s)
7:58:44 PM: "hugo" at version "unknown"
7:58:44 PM: Section completed: initializing
7:58:45 PM: 
7:58:45 PM: Netlify Build                                                 
7:58:45 PM: ────────────────────────────────────────────────────────────────
7:58:45 PM: 
7:58:45 PM: ❯ Version
7:58:45 PM:   @netlify/build 29.41.1
7:58:45 PM: 
7:58:45 PM: ❯ Flags
7:58:45 PM:   baseRelDir: true
7:58:45 PM:   buildId: 663797775c8e8100080d8e27
7:58:45 PM:   deployId: 663797775c8e8100080d8e29
7:58:45 PM: 
7:58:45 PM: ❯ Current directory
7:58:45 PM:   /opt/build/repo/content
7:58:45 PM: 
7:58:45 PM: ❯ Config file
7:58:45 PM:   /opt/build/repo/netlify.toml
7:58:45 PM: 
7:58:45 PM: ❯ Context
7:58:45 PM:   deploy-preview
7:58:46 PM: 
7:58:46 PM: ❯ Loading plugins
7:58:46 PM:    - netlify-plugin-checklinks@4.1.1 from netlify.toml
7:58:46 PM:    - @netlify/plugin-lighthouse@4.0.7 from netlify.toml
7:58:46 PM: 
7:58:46 PM: ❯ Outdated plugins
7:58:46 PM:    - @netlify/plugin-lighthouse@4.0.7: latest version is 6.0.0
7:58:46 PM:      To upgrade this plugin, please remove it from "netlify.toml" and install it from the Netlify plugins directory instead (https://app.netlify.com/plugins)
7:58:48 PM: 
7:58:48 PM: build.command from netlify.toml                               
7:58:48 PM: ────────────────────────────────────────────────────────────────
7:58:48 PM: 
7:58:48 PM: $ export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && nox ${BUILD_TARGET})
7:58:48 PM:     
7:58:48 PM:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
7:58:48 PM:                                  Dload  Upload   Total   Spent    Left  Speed
7:58:48 PM:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
7:58:48 PM:   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
7:58:48 PM: 100 3671k  100 3671k    0     0  12.5M      0 --:--:-- --:--:-- --:--:-- 12.5M
7:58:48 PM: curl: Saved to filename 'dart-sass-1.75.0-linux-x64.tar.gz'
7:58:48 PM: bash: nox: command not found
7:58:49 PM: 
7:58:49 PM: "build.command" failed                                        
7:58:49 PM: ────────────────────────────────────────────────────────────────
7:58:49 PM: 
7:58:49 PM:   Error message
7:58:49 PM:   Command failed with exit code 127: export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && nox ${BUILD_TARGET}) (https://ntl.fyi/exit-code-127)
7:58:49 PM: 
7:58:49 PM:   Error location
7:58:49 PM:   In build.command from netlify.toml:
7:58:49 PM:   export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && nox ${BUILD_TARGET})
7:58:49 PM: 
7:58:49 PM:   Resolved config
7:58:49 PM:   build:
7:58:49 PM:     base: /opt/build/repo/content
7:58:49 PM:     command: |-
7:58:49 PM:       export DART_SASS_TARBALL="dart-sass-${DART_SASS_VERSION}-linux-x64.tar.gz" && (cd /tmp && curl -LJO ${DART_SASS_URL}/${DART_SASS_VERSION}/${DART_SASS_TARBALL} && tar -xf ${DART_SASS_TARBALL} && rm ${DART_SASS_TARBALL}) && export PATH=/tmp/dart-sass:$PATH && (cd ../.. && ln -s repo scientific-python-hugo-theme) && (cd .. && nox ${BUILD_TARGET})
7:58:49 PM: 
7:58:49 PM:     commandOrigin: config
7:58:49 PM:     environment:
7:58:49 PM:       - REVIEW_ID
7:58:49 PM:       - PYTHON_VERSION
7:58:49 PM:       - HUGO_VERSION
7:58:49 PM:       - DART_SASS_VERSION
7:58:49 PM:       - DART_SASS_URL
7:58:49 PM:     ignore: 'false'
7:58:49 PM:     publish: /opt/build/repo/content/public
7:58:49 PM:     publishOrigin: config
7:58:49 PM:   plugins:
7:58:49 PM:     - inputs:
7:58:49 PM:         checkExternal: false
7:58:49 PM:         recursive: true
7:58:49 PM:       origin: config
7:58:49 PM:       package: netlify-plugin-checklinks
7:58:49 PM:     - inputs: {}
7:58:49 PM:       origin: config
7:58:49 PM:       package: '@netlify/plugin-lighthouse'
7:58:49 PM:   redirects:
7:58:49 PM:     - from: /benchmarks
7:58:49 PM:       status: 301
7:58:49 PM:       to: https://pybamm-team.github.io/pybamm-bench/
7:58:49 PM:     - from: /slack
7:58:49 PM:       status: 301
7:58:49 PM:       to: https://join.slack.com/t/pybamm/shared_invite/zt-1xwnvkqrb-6ZKgB8yBU3zuzH91USdv_A
7:58:50 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
7:58:50 PM:     - from: /*
      status: 404
      to: /404/
  redirectsOrigin: config
7:58:50 PM: Build failed due to a user error: Build script returned non-zero exit code: 2
7:58:50 PM: Failing build: Failed to build site
7:58:50 PM: Finished processing build request in 32.153s

It looks like you need to do python -m pip install nox as well.

Bashamega · 2024-05-06T14:51:13Z

Will you merge the pr?

agriyakhetarpal · 2024-05-06T15:55:47Z

Will you merge the pr?

I pushed a few more changes (table of contents, CSS overrides, some restructuring). Deployment checks are now passing

Bashamega · 2024-05-06T16:02:52Z

Will you merge the pr?

I pushed a few more changes (table of contents, CSS overrides, some restructuring). Deployment checks are now passing

Ok

arjxn-py

Thanks @Bashamega, this is well done.
Looks like we've switched to dark theme instead of addition of dark theme?

Bashamega · 2024-05-06T17:12:58Z

Thanks @Bashamega, this is well done. Looks like we've switched to dark theme instead of addition of dark theme?

It is by your default browser preferences. But they are working on it here: scientific-python/scientific-python-hugo-theme#566

arjxn-py

Thanks for the prompt response @Bashamega, this looks good to me overall then :)

Bashamega · 2024-05-06T17:16:50Z

Thanks for the prompt response @Bashamega, this looks good to me overall then :)

Your welcome

Bashamega · 2024-05-06T17:26:57Z

I accidently re requested the review sorry :(

agriyakhetarpal

No worries

Bashamega and others added 4 commits May 4, 2024 15:16

Theme Update

e67c2e1

Merge branch 'pybamm-team:main' into main

38ef211

Short Codes Updates

4212d99

style: pre-commit fixes

c6f7b15

agriyakhetarpal reviewed May 4, 2024

View reviewed changes

Netlify Packages update

e76fd37

Bashamega requested a review from agriyakhetarpal May 5, 2024 04:04

Bashamega and others added 2 commits May 5, 2024 12:42

Netlify.toml updare

733f4f5

style: pre-commit fixes

ae58bcd

agriyakhetarpal reviewed May 5, 2024

View reviewed changes

netlify.toml Outdated Show resolved Hide resolved

Changes make to nox

1f29038

Link to Training section directly

f1d2946

agriyakhetarpal added 10 commits May 6, 2024 20:38

Override basic post layout for adding ToC

d2dfeff

Add ToC to Contribute page

91e4a96

Add ToC to Learn page

e6d910e

Update title for Changelog page

f948818

Reorganise Contact page to Community

b7d9dd1

Add LinkedIn link for Scott Marquis

ea5fc1e

Rename Contact page to Community

6473604

Ensure navbar is on top + comments

193635d

https://ion-works.com ➡️ https://ionworks.com

66cd5ae

Contact ➡️ Community

ce990c1

agriyakhetarpal requested a review from arjxn-py May 6, 2024 15:54

agriyakhetarpal requested a review from valentinsulzer May 6, 2024 15:55

agriyakhetarpal changed the title ~~Theme Update~~ Add dark mode theme to website May 6, 2024

Remove Contribute and Twitter headings from navbar

d848d8f

arjxn-py reviewed May 6, 2024

View reviewed changes

arjxn-py approved these changes May 6, 2024

View reviewed changes

Bashamega requested review from agriyakhetarpal and arjxn-py May 6, 2024 17:25

agriyakhetarpal approved these changes May 6, 2024

View reviewed changes

agriyakhetarpal removed the request for review from arjxn-py May 6, 2024 17:27

agriyakhetarpal merged commit 4262061 into pybamm-team:main May 6, 2024
6 checks passed

agriyakhetarpal linked an issue May 6, 2024 that may be closed by this pull request

Dark Mode Theme #138

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dark mode theme to website #139

Add dark mode theme to website #139

Bashamega commented May 4, 2024

netlify bot commented May 4, 2024 •

edited

Loading

netlify bot commented May 4, 2024 •

edited

Loading

agriyakhetarpal commented May 4, 2024 •

edited

Loading

agriyakhetarpal left a comment

agriyakhetarpal commented May 4, 2024

agriyakhetarpal commented May 4, 2024 •

edited

Loading

Bashamega commented May 5, 2024

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024 •

edited

Loading

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024 •

edited

Loading

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024

Bashamega commented May 5, 2024

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024

Bashamega commented May 6, 2024

agriyakhetarpal commented May 6, 2024

Bashamega commented May 6, 2024

arjxn-py left a comment

Bashamega commented May 6, 2024

arjxn-py left a comment

Bashamega commented May 6, 2024

Bashamega commented May 6, 2024

agriyakhetarpal left a comment

Add dark mode theme to website #139

Add dark mode theme to website #139

Conversation

Bashamega commented May 4, 2024

netlify bot commented May 4, 2024 • edited Loading

❌ Deploy Preview for pybamm-developer-preview failed.

netlify bot commented May 4, 2024 • edited Loading

✅ Deploy Preview for pybamm-developer-preview ready!

agriyakhetarpal commented May 4, 2024 • edited Loading

agriyakhetarpal left a comment

Choose a reason for hiding this comment

agriyakhetarpal commented May 4, 2024

agriyakhetarpal commented May 4, 2024 • edited Loading

Bashamega commented May 5, 2024

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024 • edited Loading

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024 • edited Loading

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024

Bashamega commented May 5, 2024

Bashamega commented May 5, 2024

agriyakhetarpal commented May 5, 2024

Bashamega commented May 6, 2024

agriyakhetarpal commented May 6, 2024

Bashamega commented May 6, 2024

arjxn-py left a comment

Choose a reason for hiding this comment

Bashamega commented May 6, 2024

arjxn-py left a comment

Choose a reason for hiding this comment

Bashamega commented May 6, 2024

Bashamega commented May 6, 2024

agriyakhetarpal left a comment

Choose a reason for hiding this comment

netlify bot commented May 4, 2024 •

edited

Loading

netlify bot commented May 4, 2024 •

edited

Loading

agriyakhetarpal commented May 4, 2024 •

edited

Loading

agriyakhetarpal commented May 4, 2024 •

edited

Loading

agriyakhetarpal commented May 5, 2024 •

edited

Loading

agriyakhetarpal commented May 5, 2024 •

edited

Loading