Avoid too long solr uris #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion ids in query
…requests with all a users' collections ids in them
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Various situations arise when there are a lot of collections that belong to a user in which big long queries that include all of those collection ids cause solr to carp about URIs that are too long. By making post rather than get requests in a small collection of places these errors are avoided.
Refs #473
Expected Behavior Before Changes
300+ collections cause dashboard and collection pages (when logged in) to fail
Expected Behavior After Changes
Dashboard and collection pages load even if there are many many collections
Screenshots / Video
Notes
My understanding is that the pre-Valkyrisation in Hyrax 3.5 may help with this issue