Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☄️ IiifPrint x Valkyrie EPIC #312

Open
9 of 11 tasks
Tracked by #35
ShanaLMoore opened this issue Jan 4, 2024 · 3 comments
Open
9 of 11 tasks
Tracked by #35

☄️ IiifPrint x Valkyrie EPIC #312

ShanaLMoore opened this issue Jan 4, 2024 · 3 comments
Labels
Blocked IiifPrint

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 4, 2024 •
edited by laritakr

Valkyrize IiifPrint. It should work with both valkyrie and active fedora applications.

Tasks

Consider adding listeners to mimic active record call backs:

https://assaydepot.slack.com/archives/C0313NKG2DA/p1704392246521249

NOTES

Another related ticket
@ShanaLMoore ShanaLMoore mentioned this issue Jan 4, 2024
Closed
52 tasks
@ShanaLMoore ShanaLMoore changed the title Make IiifPrint work with Valkyrie IiifPrint x Valkyrie Jan 9, 2024
@ShanaLMoore
Copy link
Contributor Author

restrict hyrax version that iiif print support.

@jeremyf
Copy link
Contributor

jeremyf commented Jan 17, 2024

restrict hyrax version that iiif print support.

I don't think we want to overly restrict; I'd rather spend some time allowing for configurations to address the different versions we're supporting.

Consider that we have some IIIF Print applications on Hyrax 2.9.6 and some on what will be Hyrax 5. With #313 we have a pattern for how we can work with both.

@ShanaLMoore ShanaLMoore mentioned this issue Jan 18, 2024
Merged
jeremyf added a commit that referenced this issue Jan 18, 2024
@jeremyf
🎁 Add Transaction for Cleaning Up Split Pages
43c8c36 
Valkyrie leverages transactions instead of the actor stack; as such we
need to mirror the actor stack behavior as a transaction (or listener).
In this case, we should use a transaction.

Related to:

- #312
@jeremyf jeremyf mentioned this issue Jan 18, 2024
Merged
jeremyf added a commit that referenced this issue Jan 18, 2024
@jeremyf
🎁 Add Transaction for Cleaning Up Split Pages
4066e57 
Valkyrie leverages transactions instead of the actor stack; as such we
need to mirror the actor stack behavior as a transaction (or listener).
In this case, we should use a transaction.

Related to:

- #312
jeremyf added a commit that referenced this issue Jan 18, 2024
@jeremyf
🎁 Add Transaction for Cleaning Up Split Pages
447f18e 
Valkyrie leverages transactions instead of the actor stack; as such we
need to mirror the actor stack behavior as a transaction (or listener).
In this case, we should use a transaction.

Related to:

- #312
jeremyf added a commit that referenced this issue Jan 18, 2024
@jeremyf
🎁 Add listener for handling file set attachment
fdbb925 
Why a listener and not a transaction?  In part because the moment I want
to perform the conditional enqueuing is at the point where the
`Hyrax::WorkUploadsHandler` does it's job.  That is when we have:

- the parent work
- the file set
- the original file
- the user

The `Hyrax::WorkUploadsHandler` is most analogous to the behavior in
`Hyrax::Actors::FileSetActor#attach_to_work` and
`Hyrax::Actors::FileSetActor#create_content`.  Fortunately, Hyrax's
transaction and upload handler remove the conditional handling we needed
between uploading a remote file and directly uploading a file.

Related to:

- scientist-softserv/hykuup_knapsack#35
- scientist-softserv/hykuup_knapsack#99
- #312
@jeremyf jeremyf mentioned this issue Jan 18, 2024
Merged
jeremyf added a commit that referenced this issue Jan 19, 2024
@jeremyf
🎁 Add listener for handling file set attachment
a0ea1de 
Why a listener and not a transaction?  In part because the moment I want
to perform the conditional enqueuing is at the point where the
`Hyrax::WorkUploadsHandler` does it's job.  That is when we have:

- the parent work
- the file set
- the original file
- the user

The `Hyrax::WorkUploadsHandler` is most analogous to the behavior in
`Hyrax::Actors::FileSetActor#attach_to_work` and
`Hyrax::Actors::FileSetActor#create_content`.  Fortunately, Hyrax's
transaction and upload handler remove the conditional handling we needed
between uploading a remote file and directly uploading a file.

Related to:

- scientist-softserv/hykuup_knapsack#35
- scientist-softserv/hykuup_knapsack#99
- #312
kirkkwang pushed a commit that referenced this issue Jan 22, 2024
@jeremyf @kirkkwang
🎁 Add listener for handling file set attachment
e21cd78 
Why a listener and not a transaction?  In part because the moment I want
to perform the conditional enqueuing is at the point where the
`Hyrax::WorkUploadsHandler` does it's job.  That is when we have:

- the parent work
- the file set
- the original file
- the user

The `Hyrax::WorkUploadsHandler` is most analogous to the behavior in
`Hyrax::Actors::FileSetActor#attach_to_work` and
`Hyrax::Actors::FileSetActor#create_content`.  Fortunately, Hyrax's
transaction and upload handler remove the conditional handling we needed
between uploading a remote file and directly uploading a file.

Related to:

- scientist-softserv/hykuup_knapsack#35
- scientist-softserv/hykuup_knapsack#99
- #312
@jeremyf jeremyf mentioned this issue Jan 22, 2024
Merged
@ShanaLMoore ShanaLMoore changed the title IiifPrint x Valkyrie ☄️ IiifPrint x Valkyrie EPIC Jan 25, 2024
@ShanaLMoore ShanaLMoore mentioned this issue Feb 2, 2024
Closed
5 tasks
@laritakr laritakr mentioned this issue Apr 17, 2024
Closed
@jillpe
Copy link

jillpe commented May 23, 2024

Blocked: Waiting to be updated in hyku

@jillpe jillpe added the Blocked label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocked IiifPrint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremyf @ShanaLMoore @jillpe