Bug: 500 error when adding work to collection

[ndroark]

Attempting to add Letter to Chancy Butler, February 10th, 1862 to the Ovid Butler Digital Collection in butler.hykucommons.org produces a 500 error.

Acceptance Criteria

• Works can be added to a collection through the UI
• The Letter to Chancy Butler, February 10th, 1862 can be added to Ovid Butler Digital Collection

Testing

• Create a work with a location value
• Add work to a collection

Verify that add to collection is successful.

[ShanaLMoore]

[bkiahstroud]

This seems like it may be an issue between Wings, the OrderAlready gem, and the based_near field in Hyrax v3.6.0:

# based_near value: [#<Hyrax::ControlledVocabularies::Location:0x9c234 ID:<https://sws.geonames.org/4259418/>>]

af_work = GenericWork.find(<id>)
wings_work = Hyrax.query_service.find_by(id: <id>) # instance of Hyrax::Work

af_work.save!
=> true

Hyrax.persister.save(resource: wings_work)
=> Traceback (most recent call last):
        6: from (irb):113
        5: from config/initializers/order_already_overrides.rb:13:in `serialize'
        4: from config/initializers/order_already_overrides.rb:29:in `sanitize'
        3: from config/initializers/order_already_overrides.rb:29:in `each_with_index'
        2: from config/initializers/order_already_overrides.rb:29:in `each'
        1: from config/initializers/order_already_overrides.rb:30:in `block in sanitize'
NoMethodError (undefined method `empty?' for #<RDF::URI:0x9a420 URI:https://sws.geonames.org/4259418/>)

I’m pretty sure the error is being thrown on this line:

# Wings::ActiveFedoraConverter#apply_attributes_to_model
af_object.attributes = converted_attrs

My current theory is that it may somehow be related to how OrderAlready overrides based_near=, OR how it doesn’t override based_near= for the Wings version of the record

[laritakr]

✅ Passed QA

Created work https://demo.commons-archive.org/concern/generic_works/3b3e113f-4648-4730-a451-229e918589ba?locale=en
Added work to collection https://demo.commons-archive.org/collections/bd47476a-ab14-4688-a82d-b29574ea4a8b?locale=en