Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Location name field #964

Closed
8 tasks
ndroark opened this issue Jan 26, 2024 · 4 comments
Closed
8 tasks

Set up Location name field #964

ndroark opened this issue Jan 26, 2024 · 4 comments
Assignees
Labels
maintenance bills to maintenance

Comments

@ndroark
Copy link
Collaborator

ndroark commented Jan 26, 2024

Summary

The Location field relies on GeoNames Web Service. The functionality for this was present but past update broke this integration.

We would like to

  1. Restore the basic functionality of this field in the standard work upload editor and
  2. Ensure that when incompatible data has been entered in this field (as through Bulkrax import), the work can be edited rather than returning a 500 error when one attempts to edit.

Acceptance Criteria

  • The location field is functional in the UI
  • When incompatible data is entered into the Location field on a Bulkrax import/creation of new works, the user can edit it and it saves
  • Location values round-trip correctly

Testing

  • Make sure in the tenant Account settings, there is a valid geonames username (ask me for one if you don't have one) -Kirk
  • Import from csv generic_work_locations_test.csv
  • Export data (NOTE: the locations will now be URIs in the exported CSV)
  • Modify work titles in export CSV
  • Import from export CSV

Verify that titles update and location values still look the same

Note

The GeoNames web service username must be specified on each tenant's configuration for this to work in that tenant.

@ndroark ndroark added the maintenance bills to maintenance label Jan 26, 2024
@ShanaLMoore
Copy link
Contributor

may be related? scientist-softserv/adventist-dl#693

@jillpe
Copy link

jillpe commented Mar 1, 2024

possibly related to

@jillpe
Copy link

jillpe commented Mar 1, 2024

The location field appears to be functional in demo.commons-archive.org. Still need to verify if it's still broken on the bulkrax part or not

@kirkkwang kirkkwang self-assigned this Mar 7, 2024
laritakr added a commit that referenced this issue Mar 8, 2024
Ordering based_near causes several issues:
- adding a work to a collection fails
- adding a work outside of the actor stack turned the attribute into a string.

Refs:
- #892
- #964
@jillpe
Copy link

jillpe commented Mar 12, 2024

SoftServ QA: ✅
Updated Importer

Screenshots

Image

Image

@jillpe jillpe closed this as completed Mar 19, 2024
@jillpe jillpe reopened this Mar 19, 2024
@jillpe jillpe closed this as completed Mar 19, 2024
ShanaLMoore pushed a commit to samvera/hyku that referenced this issue Mar 21, 2024
Ordering based_near causes several issues:
- adding a work to a collection fails
- adding a work outside of the actor stack turned the attribute into a string.

Refs:
- scientist-softserv/palni-palci#892
- scientist-softserv/palni-palci#964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance bills to maintenance
Projects
Status: Done
Development

No branches or pull requests

4 participants