Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"clean" does not clean out all old artifacts from ${imagej.app.directory}/plugins/ #6

Closed
dscho opened this issue Apr 19, 2014 · 1 comment

Comments

@dscho
Copy link
Contributor

dscho commented Apr 19, 2014

When running ./Build.sh clean in Fiji (i.e. using MiniMaven), only artifacts with current version suffixes are removed. However, it is common to occasionally see older versions of the same artifacts in the jars and plugins folders. One would expect MiniMaven to clean those out as well when run with the clean target.

Though clean does not remove them, MiniMaven will remove them at build time when rebuilding those artifacts at newer versions. However, it can be argued that that behavior is less intuitive, and that furthermore, it is desirable to truly have a clean working copy without any old artifacts after clean has been run.

This issue was originally reported as fiji/fiji#36 by @ctrueden.

dscho added a commit that referenced this issue Apr 19, 2014
It is counterintuitive when installing removes other versions from the
ImageJ.app/ directory, but cleaning does not even remove the artifact
which would be installed.

So let's fix that bug.

Reported by Curtis Rueden in:

	#6

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Apr 19, 2014
This branch addresses #6.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Contributor Author

dscho commented Apr 19, 2014

Fixed as per 58b0584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant