Skip to content

Commit

Permalink
Fix duplicate moduleService parameter
Browse files Browse the repository at this point in the history 
See:
https://forum.image.sc/t/error-with-search-options-dialog/30948
  • Loading branch information
@ctrueden
ctrueden committed Nov 1, 2019
1 parent 9fcb52c commit 089606b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion src/main/java/org/scijava/command/DynamicCommand.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public abstract class DynamicCommand extends DefaultMutableModule implements
private PluginService pluginService;

@Parameter
private ModuleService moduleService;
protected ModuleService moduleService;

private DynamicCommandInfo info;

Expand Down
4 changes: 0 additions & 4 deletions src/main/java/org/scijava/options/OptionsPlugin.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.scijava.command.DynamicCommand;
import org.scijava.event.EventService;
import org.scijava.module.ModuleItem;
import org.scijava.module.ModuleService;
import org.scijava.options.event.OptionsEvent;
import org.scijava.plugin.Parameter;
import org.scijava.plugin.SingletonPlugin;
Expand Down Expand Up @@ -84,9 +83,6 @@ public abstract class OptionsPlugin extends DynamicCommand implements
@Parameter
private PrefService prefService;

@Parameter
private ModuleService moduleService;

// -- OptionsPlugin methods --

/** Loads option values from persistent storage. */
Expand Down

1 comment on commit 089606b

@imagesc-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/commandservice-within-dynamiccommand/42846/2

Please sign in to comment.