Skip to content

Commit

Permalink
ModuleSearcher: remove validity restriction
Browse files Browse the repository at this point in the history
In contrast to the visible and enabled checks, verifying that a
command is valid triggers class loading and parameter parsing.

It also hopefully avoids problems like this:
http://forum.imagej.net/t/a-search-bar-for-imagej/6735/12
  • Loading branch information
ctrueden committed Dec 29, 2017
1 parent c6cc20d commit e2ce266
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/main/java/org/scijava/search/module/ModuleSearcher.java
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,7 @@ public static String location(final ModuleInfo info, final String baseDir) {
// -- Helper methods --

private boolean isGoodModule(final ModuleInfo info) {
return info.isValid() && info.isVisible() && info.isEnabled() &&
title(info) != null;
return info.isVisible() && info.isEnabled() && title(info) != null;
}

private boolean startsWith(final ModuleInfo info, final String desiredLower) {
Expand Down

0 comments on commit e2ce266

Please sign in to comment.