Added support for GIFs. Fixes #5 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding back whitespace Added back all other tests Added debug clause for good measure Added assertions for 4d arrays Fixed assertion against array width/height Added data handle for 4d arrays Aded animated GIF test case Added frame logic to GIF Added proper assertion for GIF reader Fixed up width/height comparison Added frameless GIF test case Adding test for GIF
|
Any idea when this can be reviewed/merged? |
|
Whoops! Didn't realize this was still open! |
mikolalysenko
added a commit
that referenced
this pull request
Nov 12, 2014
Added support for GIFs. Fixes #5
|
Thanks! Merged and published! |
|
Awesome, thanks for the quick review and merge =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support all basic image formats, we are adding support for
GIF. This includes support for animated GIFs, meaning 4d arrays. I chose to use checkerboards for the patterns since GIFs have a limited color palette and we have already tested monochrome upcasting in other cases.In this PR: