Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support saving as gif #5

Closed
twolfson opened this issue Oct 3, 2014 · 3 comments
Closed

Support saving as gif #5

twolfson opened this issue Oct 3, 2014 · 3 comments

Comments

@twolfson
Copy link
Contributor

twolfson commented Oct 3, 2014

As initially posted in #4, it would be nice to have gif support since it is supported in get-pixels. One library that can be used for this is:

https://github.com/twolfson/gif-encoder

@twolfson
Copy link
Contributor Author

Going to sit on this until #6 and #7 get landed. It can be very tricky working with 3 branches that depend on each other/have conflicts x_x

@mikolalysenko
Copy link
Member

Yeah, I appreciate your patience. Thank you so much for all of your PRs! I am sorry that I have been a bit slow getting things merged, was very busy last week with teaching and didn't get much time to hack on stuff.

@twolfson
Copy link
Contributor Author

No worries, these PRs aren't blocking anything time sensitive.

About this issue: I think with GIFs we are going to need to add support for a 4d array to match the signature of get-pixels.

[numFrames, width, height, 4]

https://github.com/mikolalysenko/get-pixels

mikolalysenko added a commit that referenced this issue Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants