Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD/CLN: Isolate dependencies. #316

Merged
merged 1 commit into from Aug 26, 2015
Merged

BLD/CLN: Isolate dependencies. #316

merged 1 commit into from Aug 26, 2015

Conversation

danielballan
Copy link
Member

  • Do a little more to isolate parts of the code that require particular dependencies from those that work just fine with numpy alone.
  • Add a requirements.txtand an optional-requirements.txt to clarify dependencies for users.
  • Also split essential and optional dependencies in docs.
  • Pin the version of lmfit to 0.8.1. We are broken on 0.8.2 and 0.8.3 (latest) and no one has noticed. @licode can you look at this?

This was referenced Aug 25, 2015
Closed
Merged
ericdill
ericdill reviewed Aug 26, 2015
View reviewed changes
.travis.yml
- source activate testenv
- pip install lmfit==0.8.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 0.8.1 and not 0.8.3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drink some coffee and read the PR again. :- )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that we are pinning 0.0.4 to lmfit 0.8.1, correct?

ericdill added a commit that referenced this pull request Aug 26, 2015
@ericdill
Merge pull request #316 from danielballan/deps
e91b87a 
BLD/CLN: Isolate dependencies.
@ericdill ericdill merged commit e91b87a into scikit-beam:master Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielballan @ericdill