Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS arm64 or universal2 wheels #41

Closed
thewtex opened this issue Apr 21, 2021 · 14 comments
Closed

Add macOS arm64 or universal2 wheels #41

thewtex opened this issue Apr 21, 2021 · 14 comments

Comments

@thewtex
Copy link
Member

thewtex commented Apr 21, 2021

xref scikit-build/cmake-python-distributions#132

@henryiii
Copy link
Contributor

@mayeut will you have time to to do this? Or should I plan to work on it in the future? We could also move to cibuildwheel, I think.

@mayeut
Copy link
Contributor

mayeut commented May 20, 2021

As of now, I've just been looking how to upgrade the ninja version and there's one question which comes to my mind @jcfr probably has answer to:
I see that the upstream ninja repo now provides a universal2 binary however, this repo uses the Kitware fork to provide the make-style jobserver support.

I see multiple options and would like to know which one is appropriate:

  • update with upstream 1.10.2
  • Ask Kitware to release a 1.10.2 with make-style jobserver support and a universal binary.
  • rebuild from current sources

If the answer is to build from sources, I'll have no way to test universal2 (no way to test in other cases as well but I'd rely on upstream or Kitware testing their released artifacts).

@jcfr
Copy link
Contributor

jcfr commented May 20, 2021

Thanks for the derailed summary.

I ask the CMake team to publish arm64 binaries. Will update this issue when I hear back.

@henryiii
Copy link
Contributor

I've got an M1 and am happy to test if you need me to.

@jcfr
Copy link
Contributor

jcfr commented May 21, 2021

Will update this issue when I hear back.

It turns out my colleagues are working on this.
See https://gitlab.kitware.com/utils/ci-utilities/-/merge_requests/11

I've got an M1 and am happy to test if you need me to.

That is great.

@mathstuf and bradking: If needed, @henryiii offered to help test.

@mayeut
Copy link
Contributor

mayeut commented May 22, 2021

It turns out my colleagues are working on this.

great news.

I've got an M1 and am happy to test if you need me to.

Thanks @henryiii, have you been able to test cmake ? (I wouldn't expect any issues)

will you have time to to do this? Or should I plan to work on it in the future? We could also move to cibuildwheel, I think.

I can prepare the same work as is being done on cmake to move to cibuildwheel.

@henryiii
Copy link
Contributor

have you been able to test cmake

Yes, just a very basic install and --help so far, but that worked fine.

@henryiii
Copy link
Contributor

henryiii commented Jul 4, 2021

Looks like the linked MR was merged two weeks ago. What's the status for a release we can package (not sure where to find that in the repo)?

@mayeut
Copy link
Contributor

mayeut commented Jul 17, 2021

What's the status for a release we can package (not sure where to find that in the repo)?

I can see the tag in the Kitware repo but there's no release and no binary assets associated with that tag: https://github.com/Kitware/ninja/releases/tag/v1.10.2.g51db2.kitware.jobserver-1

@jcfr, can you check with your colleagues about that please ?

@mathstuf
Copy link

Binaries are available here: https://gitlab.kitware.com/utils/ci-utilities/-/releases/ninja%252Fv1.10.2.g51db2.kitware.jobserver-1

We already have gitlab-ci set up with access to macOS and Windows machines which seems to still be difficult on GitHub actions, so we just reused that infrastructure.

@mayeut
Copy link
Contributor

mayeut commented Jul 18, 2021

Thanks for the links @mathstuf

FYI, the Windows archive returns a 404 not found error on my end.

Given we're already building from source for almost all architectures and that the build seems much simpler than the one for CMake (and also much shorter), I wonder if we would be better off building everything from sources (using cmake rather than python bootstrap as is done in Kitware CI and also upstream CI) ? I will draft something for this. The only gotcha is that it might require to wait for a new release of scikit-build or some clever tricks for universal2 if going this way ?

@mathstuf
Copy link

FYI, the Windows archive returns a 404 not found error on my end.

Hmm. Somehow the Windows binary got missed in the upload glob? I'll look at that next week.

This was referenced Jul 18, 2021
@mathstuf
Copy link

I fixed the Windows release binary URL and the script which makes the GitLab release for future releases.

@mayeut
Copy link
Contributor

mayeut commented Jul 28, 2021

fixed by #63

@mayeut mayeut closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants