New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS arm64 or universal2 wheels #41
Comments
@mayeut will you have time to to do this? Or should I plan to work on it in the future? We could also move to cibuildwheel, I think. |
As of now, I've just been looking how to upgrade the ninja version and there's one question which comes to my mind @jcfr probably has answer to: I see multiple options and would like to know which one is appropriate:
If the answer is to build from sources, I'll have no way to test universal2 (no way to test in other cases as well but I'd rely on upstream or Kitware testing their released artifacts). |
Thanks for the derailed summary. I ask the CMake team to publish arm64 binaries. Will update this issue when I hear back. |
I've got an M1 and am happy to test if you need me to. |
It turns out my colleagues are working on this.
That is great. @mathstuf and bradking: If needed, @henryiii offered to help test. |
great news.
Thanks @henryiii, have you been able to test cmake ? (I wouldn't expect any issues)
I can prepare the same work as is being done on cmake to move to cibuildwheel. |
Yes, just a very basic install and |
Looks like the linked MR was merged two weeks ago. What's the status for a release we can package (not sure where to find that in the repo)? |
I can see the tag in the Kitware repo but there's no release and no binary assets associated with that tag: https://github.com/Kitware/ninja/releases/tag/v1.10.2.g51db2.kitware.jobserver-1 @jcfr, can you check with your colleagues about that please ? |
Binaries are available here: https://gitlab.kitware.com/utils/ci-utilities/-/releases/ninja%252Fv1.10.2.g51db2.kitware.jobserver-1 We already have gitlab-ci set up with access to macOS and Windows machines which seems to still be difficult on GitHub actions, so we just reused that infrastructure. |
Thanks for the links @mathstuf FYI, the Windows archive returns a 404 not found error on my end. Given we're already building from source for almost all architectures and that the build seems much simpler than the one for CMake (and also much shorter), I wonder if we would be better off building everything from sources (using cmake rather than python bootstrap as is done in Kitware CI and also upstream CI) ? I will draft something for this. The only gotcha is that it might require to wait for a new release of scikit-build or some clever tricks for universal2 if going this way ? |
Hmm. Somehow the Windows binary got missed in the upload glob? I'll look at that next week. |
I fixed the Windows release binary URL and the script which makes the GitLab release for future releases. |
fixed by #63 |
xref scikit-build/cmake-python-distributions#132
The text was updated successfully, but these errors were encountered: