Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use cibuildwheel #46

Merged
merged 5 commits into from Jul 4, 2021
Merged

ci: use cibuildwheel #46

merged 5 commits into from Jul 4, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented May 22, 2021

As discussed in #41, rework CI to use cibuildwheel & GHA.

I will split in multiple PRs & update this list accordingly:

  • Use same convert_to_generic_platform_wheel script as cmake: 104b0ca
    Prepare for universal2, allow to create py2.py3 wheels
    Available in standalone PR chore: use same convert_to_generic_platform_wheel.py script as cmake #49
  • repair_wheel.py script: 0f23004
    Create py2.py3 wheels, ensures delocate/auditwheel are used on macOS/Linux to check the wheels.
  • Update requirements: f2e0802
    Multiple requirements allow to install only what's needed for a given stage.
  • use cibuildwheel: e31875a
    Use cibuildwheel to build wheels, move everything to GHA, remove CircleCI, AppVeyor, TravisCI & scikitci

GHA workflow can be seen on my fork

pre-requisite: #49

@mayeut mayeut marked this pull request as ready for review May 22, 2021 14:35
@mayeut mayeut marked this pull request as draft May 24, 2021 10:30
@mayeut
Copy link
Contributor Author

mayeut commented May 24, 2021

converted to draft, let's try to split this a bit for easier reviews.

@mayeut mayeut force-pushed the cibuildwheel branch 2 times, most recently from fbaab71 to 35900fe Compare June 2, 2021 21:44
This prepares for `universal2` wheels and allows to create `py2.py3` wheels
@mayeut mayeut force-pushed the cibuildwheel branch 2 times, most recently from 5ffd3df to 9387e5b Compare July 3, 2021 19:17
@mayeut mayeut marked this pull request as ready for review July 4, 2021 09:04
@mayeut
Copy link
Contributor Author

mayeut commented Jul 4, 2021

@henryiii, @jcfr,

I'll merge this one in about 8 hours if you have no objections by then.
It's very similar to what's been done on CMake and will allow to move forward scikitci, travisci, ... having issues right now. I will try to enhance this once this gets merged similar to what @henryiii has done on CMake.

@mayeut mayeut merged commit 246e477 into scikit-build:master Jul 4, 2021
@mayeut mayeut deleted the cibuildwheel branch July 4, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants